Preserve URL hash when updating query parameters#3240
Merged
knolleary merged 1 commit intoMay 9, 2025
Merged
Conversation
Contributor
Author
|
@MichaelBDavis for testing the cloud features table, use this URL: https://deploy-preview-3240--flowforge-website.netlify.app/pricing/#feature-comparison-table And for self-hosted, use this one: https://deploy-preview-3240--flowforge-website.netlify.app/pricing/?hosting=self-hosted#feature-comparison-table Once merged, the URLs for sharing will be:
The anchor was already in place but only worked for cloud. This change ensures it works for self-hosted as well. |
knolleary
approved these changes
May 9, 2025
knolleary
deleted the
3231-add-an-anchor-link-to-the-feature-comparison-section-of-pricing-page
branch
Member
|
(spotted this as I was passing by - given the technical nature, figured Michael would appreciate an independent review. Looks good) |
Contributor
Author
|
Thanks Nick! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the URL hash (e.g., #feature-comparison-table) is preserved when updating query parameters using window.history.replaceState. Previously, the hash was lost, causing navigation issues. The solution appends the current hash to the updated URL, maintaining proper functionality for anchor links.
Related Issue(s)
Checklist