Skip to content

Yndira's job title update#3277

Merged
Yndira-E merged 1 commit into
mainfrom
yndira-job-title-update
Jun 2, 2025
Merged

Yndira's job title update#3277
Yndira-E merged 1 commit into
mainfrom
yndira-job-title-update

Conversation

@Yndira-E
Copy link
Copy Markdown
Contributor

Description

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E requested a review from ZJvandeWeg as a code owner May 26, 2025 10:15
| CSM | [Esmé](https://nl.linkedin.com/in/esméwieringa) [@Esmewieringa](https://github.com/Esmewieringa) |
| Sales | [Omar](https://ca.linkedin.com/in/omarazizahmed?trk=public_post_feed-actor-name) [@omarazizahmed](https://github.com/omarazizahmed) |
| Visual designer | [Yndira](https://www.linkedin.com/in/yndira-escobar-es/) [@Yndira-E](https://github.com/Yndira-E) |
| Marketing Manager, Website & Social Media | [Yndira](https://www.linkedin.com/in/yndira-escobar-es/) [@Yndira-E](https://github.com/Yndira-E) |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it work to do something like:

Suggested change
| Marketing Manager, Website & Social Media | [Yndira](https://www.linkedin.com/in/yndira-escobar-es/) [@Yndira-E](https://github.com/Yndira-E) |
| {{ team.yndira-escobar.title }} | [Yndira](https://www.linkedin.com/in/yndira-escobar-es/) [@Yndira-E](https://github.com/Yndira-E) |

I dont' think this example works, but eleventy does allow us to deduplicate this and keep it more dynamic?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have to be {{ team["yndira-escobar"].title }}, but that would mean repeating the same base key with different properties for the LinkedIn and GitHub links, and doing that for all team members. I tried looping through it, but it's not as straightforward as it would be in a .njk file. I'll work on a better iteration, but I'm merging as is for now.

@Yndira-E Yndira-E merged commit 25e34d1 into main Jun 2, 2025
6 checks passed
@Yndira-E Yndira-E deleted the yndira-job-title-update branch June 2, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants