Skip to content

Whitepaper landing pages update#3290

Merged
ZJvandeWeg merged 2 commits into
mainfrom
gating-whitepapers
May 30, 2025
Merged

Whitepaper landing pages update#3290
ZJvandeWeg merged 2 commits into
mainfrom
gating-whitepapers

Conversation

@Yndira-E
Copy link
Copy Markdown
Contributor

@Yndira-E Yndira-E commented May 30, 2025

Description

To increase conversions for the OSS and Innovation in Manufacturing whitepapers, we're now displaying only an introduction to the PDF content on the page instead of the full text.

Additional changes, such as new thank-you pages and improvements to the template to move all data into the front matter, will be handled in separate PRs.

Related Issue(s)

Checklist

  • I have read the contribution guidelines
  • I have considered the performance impact of these changes
  • Suitable unit/system level tests have been added and they pass
  • Documentation has been updated

@Yndira-E Yndira-E requested a review from ZJvandeWeg May 30, 2025 10:07
@@ -0,0 +1,21 @@
---
layout: layouts/base.njk
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extends is nice on line 15, but why not use this line instead?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if the layout is whitepaper, all the blocks below can be in the frontmatter?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree, and I was planning to address that in a separate PR (as mentioned in the description). This PR is focused solely on gating the two whitepapers.

Comment thread src/whitepaper/whitepaper.json
@ZJvandeWeg ZJvandeWeg enabled auto-merge May 30, 2025 11:17
@ZJvandeWeg ZJvandeWeg merged commit 54623f7 into main May 30, 2025
5 checks passed
@ZJvandeWeg ZJvandeWeg deleted the gating-whitepapers branch May 30, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants