Skip to content

[4913] Accessibility: Heading hierarchy, generic "Read More" & aria-labelledby #4914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n-lark merged 2 commits into from
Apr 23, 2026
Merged

[4913] Accessibility: Heading hierarchy, generic "Read More" & aria-labelledby #4914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08e209b
Update headings, read more labels, aria labels
n-lark Apr 21, 2026
45d2d2a
Merge branch 'main' into 4913-heading-aria-read-more
n-lark Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/_includes/benefits.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
<div class="flex flex-wrap justify-center mt-12 md:mt-20">
<div class="company-value">
{% image "./images/pictograms/remote_blue.png", "Icon representing Fully Remote", [128] %}
<h5>Fully Remote</h5>
<h3>Fully Remote</h3>
</div>
<div class="company-value">
{% image "./images/pictograms/vacation_blue.png", "Icon representing Unlimited Vacation", [128] %}
<h5>Unlimited Vacation</h5>
<h3>Unlimited Vacation</h3>
</div>
<div class="company-value">
{% image "./images/pictograms/time_blue.png", "Icon representing Flexible Hours", [128] %}
<h5>Flexible Hours</h3>
<h3>Flexible Hours</h3>
</div>
<div class="company-value">
{% image "./images/pictograms/education_blue.png", "Icon representing Education Budget", [128] %}
<h5>Education Budget</h5>
<h3>Education Budget</h3>
</div>
<div class="company-value">
{% image "./images/pictograms/equipment_blue.png", "Icon representing Equipment", [128] %}
<h5>Equipment</h5>
<h3>Equipment</h3>
</div>
<div class="company-value">
{% image "./images/pictograms/parental_leave_blue.png", "Icon representing Paid Parental Leave", [128] %}
<h5>Paid Parental Leave</h5>
<h3>Paid Parental Leave</h3>
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion src/_includes/blog/pagination.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

<nav aria-labelledby="pagination" class="pagination mt-4">
<nav aria-label="Pagination" class="pagination mt-4">
<ol class="flex flex-row w-full justify-between text-gray-600">
<li class="flex md:flex-initial w-40 justify-start pl-2 ff-nav-blog-p"{% if not pagination.href.previous %} style="opacity: 0; pointer-events: none;"{% endif %}><a href="{{ pagination.href.previous }}">Previous</a></li>
<li>
Expand Down
2 changes: 1 addition & 1 deletion src/_includes/changelog/changelog-posts.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<div class="prose">
{% include "summary.njk" %}
</div>
<a href="{{ item.url }}" class="group-hover:underline">read more...</a>
<a href="{{ item.url }}" class="group-hover:underline" aria-label="Read more about {{ item.data.title }}">read more...</a>
{% else %}
<div class="prose">
{{ item.content | safe }}
Expand Down
4 changes: 3 additions & 1 deletion src/css/style.page.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,10 @@
width: 128px;
}

.company-value h5 {
.company-value h5,
.company-value h3 {
font-size: 1.25rem;
font-weight: 600;
margin-top: 1rem;
margin-bottom: 3rem;
@apply px-2 md:px-0
Expand Down
6 changes: 3 additions & 3 deletions src/vs/kepware.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ cta:
{% include section.svgPath %}
</div>
<div class="w-full flex flex-row gap-3 mx-auto md:m-0">
<h5 class="w-full md:m-0">
<div class="text-xl text-gray-600 text-center sm:text-left">{{ section.title }}</div>
</h5>
<h3 class="w-full md:m-0">
<div class="text-xl font-semibold text-gray-600 text-center sm:text-left">{{ section.title }}</div>
</h3>
</div>
</div>
<div>
Expand Down
8 changes: 4 additions & 4 deletions src/vs/litmus.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ cta:
<div class="mx-auto grid grid-cols-1 md:grid-cols-2 gap-8 text-center md:text-left mb-20">
{% for card in blueCards %}
<div class="p-6 bg-gradient-to-r from-white to-indigo-50 border border-indigo-100 rounded-lg">
<h5 class="text-indigo-600">{{ card.title }}</h5>
<h3 class="text-indigo-600 text-xl font-semibold">{{ card.title }}</h3>
<p>{{ card.content | safe }}</p>
</div>
{% endfor %}
Expand All @@ -130,9 +130,9 @@ cta:
</div>
</div>
<div class="w-full flex flex-row gap-3 mx-auto md:m-0">
<h5 class="w-full md:m-0">
<div class="text-xl text-gray-600 text-center sm:text-left">{{ section.title }}</div>
</h5>
<h3 class="w-full md:m-0">
<div class="text-xl font-semibold text-gray-600 text-center sm:text-left">{{ section.title }}</div>
</h3>
</div>
</div>
<div>
Expand Down
Loading