Skip to content

Commit 1f7d6af

Browse files
committed
address review comments
1 parent af96a12 commit 1f7d6af

1 file changed

Lines changed: 20 additions & 8 deletions

File tree

.github/workflows/publish-agentflow.yml

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ jobs:
3737
- uses: actions/checkout@v4
3838

3939
- uses: pnpm/action-setup@v2
40+
with:
41+
version: 10.26.0
4042

4143
- uses: actions/setup-node@v4
4244
with:
@@ -46,11 +48,13 @@ jobs:
4648
- name: Validate custom version
4749
if: inputs.bump == 'custom'
4850
run: |
49-
if [ -z "${{ inputs.custom_version }}" ]; then
51+
if [ -z "$CUSTOM_VERSION" ]; then
5052
echo "::error::custom_version is required when bump is 'custom'"
5153
exit 1
5254
fi
53-
npx semver "${{ inputs.custom_version }}" || (echo "::error::Invalid semver: ${{ inputs.custom_version }}" && exit 1)
55+
npx semver "$CUSTOM_VERSION" || (echo "::error::Invalid semver: $CUSTOM_VERSION" && exit 1)
56+
env:
57+
CUSTOM_VERSION: ${{ inputs.custom_version }}
5458

5559
- name: Install dependencies
5660
run: pnpm install --frozen-lockfile
@@ -59,11 +63,14 @@ jobs:
5963

6064
- name: Set version
6165
run: |
62-
if [ "${{ inputs.bump }}" = "custom" ]; then
63-
pnpm --filter @flowiseai/agentflow exec npm version "${{ inputs.custom_version }}" --no-git-tag-version
66+
if [ "$BUMP" = "custom" ]; then
67+
pnpm --filter @flowiseai/agentflow exec npm version "$CUSTOM_VERSION" --no-git-tag-version
6468
else
65-
pnpm --filter @flowiseai/agentflow exec npm version "${{ inputs.bump }}" --preid dev --no-git-tag-version
69+
pnpm --filter @flowiseai/agentflow exec npm version "$BUMP" --preid dev --no-git-tag-version
6670
fi
71+
env:
72+
BUMP: ${{ inputs.bump }}
73+
CUSTOM_VERSION: ${{ inputs.custom_version }}
6774

6875
- name: Resolve version
6976
id: resolve-version
@@ -92,6 +99,8 @@ jobs:
9299
- uses: actions/checkout@v4
93100

94101
- uses: pnpm/action-setup@v2
102+
with:
103+
version: 10.26.0
95104

96105
- uses: actions/setup-node@v4
97106
with:
@@ -105,11 +114,14 @@ jobs:
105114

106115
- name: Set version
107116
run: |
108-
if [ "${{ inputs.bump }}" = "custom" ]; then
109-
pnpm --filter @flowiseai/agentflow exec npm version "${{ inputs.custom_version }}" --no-git-tag-version
117+
if [ "$BUMP" = "custom" ]; then
118+
pnpm --filter @flowiseai/agentflow exec npm version "$CUSTOM_VERSION" --no-git-tag-version
110119
else
111-
pnpm --filter @flowiseai/agentflow exec npm version "${{ inputs.bump }}" --preid dev --no-git-tag-version
120+
pnpm --filter @flowiseai/agentflow exec npm version "$BUMP" --preid dev --no-git-tag-version
112121
fi
122+
env:
123+
BUMP: ${{ inputs.bump }}
124+
CUSTOM_VERSION: ${{ inputs.custom_version }}
113125

114126
- name: Log version
115127
run: |

0 commit comments

Comments
 (0)