Skip to content

chore(agentflow): update ESLint configuration to include root and markdown plugin#5881

Merged
jocelynlin-wd merged 3 commits into
mainfrom
fix/agentflow-lint-config
Mar 3, 2026
Merged

chore(agentflow): update ESLint configuration to include root and markdown plugin#5881
jocelynlin-wd merged 3 commits into
mainfrom
fix/agentflow-lint-config

Conversation

@jocelynlin-wd
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the ESLint configuration for the agentflow package. It establishes the current directory as the ESLint root, preventing unintended rule inheritance from higher-level configurations. Additionally, it integrates a markdown linting plugin to enforce code style and quality within markdown code blocks, enhancing overall code consistency and maintainability.

Highlights

  • ESLint Root Configuration: The root: true property was added to the .eslintrc.js file, ensuring ESLint stops looking for configuration files in parent directories.
  • Markdown Linting Integration: The plugin:markdown/recommended extension was included in the extends array, enabling ESLint to lint code blocks within Markdown files.
  • Plugin Order Adjustment: The order of plugin:prettier/recommended and plugin:@typescript-eslint/recommended in the extends array was swapped for consistency.
Changelog
  • packages/agentflow/.eslintrc.js
    • Added root: true to mark the configuration as the project root.
    • Included plugin:markdown/recommended for linting markdown files.
    • Adjusted the order of prettier and @typescript-eslint plugins in the extends array.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ESLint configuration by adding root: true and support for linting markdown files. My review focuses on the ordering of the ESLint extensions. I've found an issue where plugin:prettier/recommended is no longer the last item in the extends array, which can cause conflicts with code formatting rules. I've suggested a fix to restore the correct order.

Comment thread packages/agentflow/.eslintrc.js Outdated
@jocelynlin-wd jocelynlin-wd requested a review from j-sanaa March 2, 2026 22:50
jocelynlin-wd and others added 2 commits March 2, 2026 14:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@jocelynlin-wd jocelynlin-wd merged commit 4d857f8 into main Mar 3, 2026
7 checks passed
@jocelynlin-wd jocelynlin-wd deleted the fix/agentflow-lint-config branch March 3, 2026 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants