Skip to content

refactor: Extract loadNodesFromDir() from NodesPool for reuse #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianwei-liu merged 2 commits into from
Mar 5, 2026
+14 −4
Merged

refactor: Extract loadNodesFromDir() from NodesPool for reuse #5904

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d877ae7
refactor: Extract loadNodesFromDir() from NodesPool for reuse
tianwei-liu Mar 4, 2026
c0037cb
Merge branch 'main' into refactor-nodespool
tianwei-liu Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions packages/server/src/NodesPool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,20 @@ export class NodesPool {
* Initialize nodes
*/
private async initializeNodes() {
const disabled_nodes = process.env.DISABLED_NODES ? process.env.DISABLED_NODES.split(',') : []
const packagePath = getNodeModulesPackagePath('flowise-components')
const nodesPath = path.join(packagePath, 'dist', 'nodes')
const nodeFiles = await this.getFiles(nodesPath)
return Promise.all(
const nodes = await this.loadNodesFromDir(nodesPath)
Object.assign(this.componentNodes, nodes)
}

/**
* Load and filter nodes from a directory.
*/
async loadNodesFromDir(dir: string): Promise<IComponentNodes> {
const disabled_nodes = process.env.DISABLED_NODES ? process.env.DISABLED_NODES.split(',') : []
const nodes: IComponentNodes = {}
const nodeFiles = await this.getFiles(dir)
await Promise.all(
nodeFiles.map(async (file) => {
if (file.endsWith('.js')) {
try {
Expand Down Expand Up @@ -69,7 +78,7 @@ export class NodesPool {
const isDisabled = disabled_nodes.includes(newNodeInstance.name)

if (conditionOne && conditionTwo && !isDisabled) {
this.componentNodes[newNodeInstance.name] = newNodeInstance
nodes[newNodeInstance.name] = newNodeInstance
}
}
} catch (err) {
Expand All @@ -78,6 +87,7 @@ export class NodesPool {
}
})
)
return nodes
}

/**
Expand Down