Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the error handling in the SSO login process to dynamically display error messages instead of a hardcoded string. A security concern was raised regarding the potential disclosure of sensitive information by exposing raw error messages from generic Error instances; it is recommended to only expose messages from specific, intentional error types like InternalFlowiseError.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Contributor
Author
|
@HenryHengZJ I was just testing something so reverted it temporarily. Will build a new image and deploy again. |
Contributor
Author
|
@HenryHengZJ reverted and deployed again.
|
HenryHengZJ
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Screen.Recording.2026-04-01.at.9.06.55.PM.mov