fix: streaming response due to high number of redis pub/sub channels, better handling of connection issues#6114
Merged
fix: streaming response due to high number of redis pub/sub channels, better handling of connection issues#6114
Conversation
…n or after successful response
…at on server start/stop
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the SSE streaming and Redis pub/sub infrastructure by introducing a heartbeat mechanism, periodic subscription cleanup, and improved error handling. The SSEStreamer now utilizes a Map for client management and a safeWrite method to handle disconnected clients gracefully. Review feedback identifies a redundant manual resubscription logic in the Redis subscriber that could lead to duplicate events, inconsistencies in the SSE message formatting, and a recommendation for a more robust nullish check on chatId.
HenryHengZJ
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow up to: #6008