fix(components): parse gcs uniform bucket access env

[haimingZZ]

Summary

• trim and parse GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS instead of coercing any non-empty string to true
• keep the default enabled behavior when the env is unset
• add a regression test for whitespace-padded false values

Validation

• git diff --check
• pnpm test -- --runInBand src/storage/GCSStorageProvider.test.ts (fails locally because packages/components/node_modules is missing in this checkout; jest is not installed yet)

[gemini-code-assist]

Code Review

This pull request improves the handling of the GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS environment variable in GCSStorageProvider by adding whitespace trimming and case-insensitive comparison, and introduces a corresponding test suite. Review feedback notes that the change alters the default behavior when the variable is unset and suggests using idiomatic top-level imports in the test file.

[gemini-code-assist]

The logic !== 'false' effectively defaults the value to true when the environment variable is unset or empty. While the PR description mentions "keeping" the default enabled behavior, the previous implementation (Boolean(process.env.GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS) ?? true) actually evaluated to false when the variable was unset (since Boolean(undefined) is false).

If the intention is to change the default to true (which is generally recommended for modern GCS buckets), this implementation is correct. However, if you intended to maintain the previous default of false, the logic should be adjusted to check for 'true' explicitly.

[gemini-code-assist]

The test uses require inside the it block, which is non-idiomatic and redundant here as the module is not being re-evaluated with jest.resetModules(). It is better to use a standard top-level import. Additionally, adding a test case for the default (unset) behavior would verify the "default enabled" requirement mentioned in the PR description.

import { GCSStorageProvider } from './GCSStorageProvider'

const bucketMock = {}
const multerMock = jest.fn((config) => config)
const storageCtorMock = jest.fn(() => ({
    bucket: jest.fn(() => bucketMock)
}))
const multerGoogleCloudStorageMock = jest.fn((config) => config)

jest.mock('@google-cloud/storage', () => ({
    Storage: storageCtorMock
}))

jest.mock('multer', () => multerMock)

jest.mock('multer-cloud-storage', () => multerGoogleCloudStorageMock)

jest.mock('@google-cloud/logging-winston', () => ({
    LoggingWinston: jest.fn()
}))

describe('GCSStorageProvider', () => {
    const originalEnv = process.env

    beforeEach(() => {
        jest.clearAllMocks()
        process.env = {
            ...originalEnv,
            GOOGLE_CLOUD_STORAGE_BUCKET_NAME: 'test-bucket',
            GOOGLE_CLOUD_STORAGE_PROJ_ID: 'test-project',
            GOOGLE_CLOUD_STORAGE_CREDENTIAL: '/tmp/gcs.json'
        }
    })

    afterAll(() => {
        process.env = originalEnv
    })

    it('treats whitespace-padded false as disabled uniform bucket access', () => {
        process.env.GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS = ' false '

        const provider = new GCSStorageProvider()
        provider.getMulterStorage()

        expect(multerGoogleCloudStorageMock).toHaveBeenCalledWith(
            expect.objectContaining({
                uniformBucketLevelAccess: false
            })
        )
    })

    it('defaults to enabled uniform bucket access when env is unset', () => {
        delete process.env.GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS

        const provider = new GCSStorageProvider()
        provider.getMulterStorage()

        expect(multerGoogleCloudStorageMock).toHaveBeenCalledWith(
            expect.objectContaining({
                uniformBucketLevelAccess: true
            })
        )
    })
})

[haimingZZ]

Addressed the Gemini follow-up in the existing PR branch.

• preserved the default true behavior explicitly when GOOGLE_CLOUD_UNIFORM_BUCKET_ACCESS is unset
• switched the test to a top-level import and added a regression for the unset-env case

Local validation remains limited in this checkout because packages/components/node_modules is missing, but git diff --check is clean.