pushed#392
Open
Hanzeeeee wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Code Review
This pull request comments out the Badge component within the Bot component. The review feedback recommends removing the code entirely to maintain cleanliness or using the existing showFooter property to manage the component's visibility instead of leaving commented-out code in the codebase.
Comment on lines
+2863
to
+2868
| {/* <Badge | ||
| footer={props.footer} | ||
| badgeBackgroundColor={props.badgeBackgroundColor} | ||
| poweredByTextColor={props.poweredByTextColor} | ||
| botContainer={botContainer} | ||
| /> | ||
| /> */} |
There was a problem hiding this comment.
Avoid leaving commented-out code in the codebase. If the Badge component is no longer needed, it should be removed entirely to maintain code cleanliness. If the intention is to make the branding optional, consider using the existing showFooter property within the footer prop instead of modifying the component structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.