add test and refactoring

Author: t-heuser

Classes/Exceptions/Http/Exception.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Flowpack\SeoRouting\Exceptions\Http;
+
+use Throwable;
+
+/**
+ * An exception where the HTTP status code can be set.
+ */
+class Exception extends \Neos\Flow\Http\Exception
+{
+    public function __construct(int $statusCode, string $message = "", int $code = 0, ?Throwable $previous = null)
+    {
+        parent::__construct($message, $code, $previous);
+
+        $this->statusCode = $statusCode;
+    }
+}

Classes/Helper/ExceptionHelper.php

@@ -5,9 +5,9 @@
 namespace Flowpack\SeoRouting;
 
 use Flowpack\SeoRouting\Enum\TrailingSlashModeEnum;
+use Flowpack\SeoRouting\Exceptions\Http\Exception as HttpException;
 use Flowpack\SeoRouting\Helper\BlocklistHelper;
 use Flowpack\SeoRouting\Helper\ConfigurationHelper;
-use Flowpack\SeoRouting\Helper\ExceptionHelper;
 use Flowpack\SeoRouting\Helper\LowerCaseHelper;
 use Flowpack\SeoRouting\Helper\TrailingSlashHelper;
 use Neos\Flow\Annotations as Flow;
@@ -34,6 +34,9 @@ class RoutingMiddleware implements MiddlewareInterface
     #[Flow\Inject]
     protected LowerCaseHelper $lowerCaseHelper;
 
+    /**
+     * @throws HttpException
+     */
     public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
     {
         $isTrailingSlashEnabled = $this->configurationHelper->isTrailingSlashEnabled();
@@ -71,9 +74,7 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
         $statusCode = $this->configurationHelper->getStatusCode();
 
         if ($statusCode >= 400) {
-            $exception = new ExceptionHelper();
-            $exception->setStatusCode($statusCode);
-            throw $exception;
+            throw new HttpException($statusCode);
         }
 
         return $this->responseFactory->createResponse($statusCode)

Classes/RoutingMiddleware.php

@@ -5,6 +5,7 @@
 namespace Flowpack\SeoRouting\Tests\Unit;
 
 use Flowpack\SeoRouting\Enum\TrailingSlashModeEnum;
+use Flowpack\SeoRouting\Exceptions\Http\Exception as HttpException;
 use Flowpack\SeoRouting\Helper\BlocklistHelper;
 use Flowpack\SeoRouting\Helper\ConfigurationHelper;
 use Flowpack\SeoRouting\Helper\LowerCaseHelper;
@@ -23,6 +24,7 @@
 use ReflectionClass;
 
 #[CoversClass(RoutingMiddleware::class)]
+#[CoversClass(HttpException::class)]
 class RoutingMiddlewareTest extends TestCase
 {
     private readonly RoutingMiddleware $routingMiddleware;
@@ -82,6 +84,7 @@ public function testProcessShouldHandleUrlsCorrectly(
         int $statusCode,
         TrailingSlashModeEnum $trailingSlashMode,
         int $handlerStatusCode = 200,
+        ?string $expectedException = null,
     ): void {
         $originalUri = new Uri($originalUrl);
         $expectedUri = new Uri($expectedUrl);
@@ -98,8 +101,12 @@ public function testProcessShouldHandleUrlsCorrectly(
         $this->requestMock->expects($this->once())->method('getUri')->willReturn($originalUri);
 
         $pathChanged = $originalUrl !== $expectedUrl;
-
-        if (!$pathChanged) {
+        if (is_string($expectedException)) {
+            $this->expectException($expectedException);
+            $this->responseFactoryMock->expects($this->never())->method('createResponse');
+            $this->routingMiddleware->process($this->requestMock, $this->requestHandlerMock);
+            return;
+        } elseif (!$pathChanged) {
             $this->requestHandlerMock->method('handle')->willReturn($this->responseMock);
         } elseif ($handlerStatusCode >= 400) {
             $this->responseMock->method('getStatusCode')->willReturn($handlerStatusCode);
@@ -122,7 +129,6 @@ public function testProcessShouldHandleUrlsCorrectly(
                 ->with('Location', (string)$expectedUri)
                 ->willReturnSelf();
         }
-
         self::assertSame(
             $this->responseMock,
             $this->routingMiddleware->process($this->requestMock, $this->requestHandlerMock)
@@ -190,6 +196,16 @@ public static function urlsDataProvider(): array
                 'trailingSlashMode' => TrailingSlashModeEnum::ADD,
                 'handlerStatusCode' => 404,
             ],
+            [
+                'originalUrl' => 'https://local.dev',
+                'expectedUrl' => 'https://local.dev/',
+                'isTrailingSlashEnabledResult' => true,
+                'isToLowerCaseEnabledResult' => false,
+                'isUriInBlocklistResult' => false,
+                'statusCode' => 404,
+                'trailingSlashMode' => TrailingSlashModeEnum::ADD,
+                'expectedException' => HttpException::class
+            ],
         ];
     }
 }