Feature/8 move multi selection processing to backend#302
Open
connykaelinvisol wants to merge 2 commits intoFlowpack:2.x-devfrom
Open
Feature/8 move multi selection processing to backend#302connykaelinvisol wants to merge 2 commits intoFlowpack:2.x-devfrom
connykaelinvisol wants to merge 2 commits intoFlowpack:2.x-devfrom
Conversation
* Move processing of multi selection actions to the backend. * Generalize action response with MutationResult. * Use helper function for Asset and Tag resolvement.
Contributor
Author
|
Within my work on this feature I noticed that there is a response handling mix for the single asset actions. I therefore standardized it to use MutationResult in every action. Even though this requires an additional |
0fa5d5c to
2b77c5b
Compare
2b77c5b to
5f7e709
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added backend support for batch asset mutations (delete, tag, untag, assign collection, update) so that multi-selection operations are processed in a single GraphQL request instead of sending individual mutations per asset from the frontend. Additionally, standardized all single-asset mutations to return MutationResult instead of a mix of Asset and MutationResult, and extracted shared validation logic into reusable helper methods.
How I did it (main changes and additional fixes)
Backend:
Frontend: