Skip to content

Commit 25a77b1

Browse files
fix(bridge): register int:rtt_samples param kind for the distributed bench preset
mlx-distributed-spec-decode-bench's rtt_samples needs a higher cap than n_samples (50); add MAX_RTT_SAMPLES=5000 and the int:rtt_samples validator entry. Co-authored-by: FluffyAIcode <FluffyAIcode@users.noreply.github.com>
1 parent 47e1652 commit 25a77b1

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

inference_engine/bridge/manifest.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
# bridge is for evidence runs and debugging, not for monopolizing the
3030
# single Mac with open-ended workloads.
3131
MAX_N_SAMPLES = 50
32+
MAX_RTT_SAMPLES = 5000 # gRPC RTT bench: enough samples for a stable p99
3233
MAX_NEW_TOKENS = 2048 # backstop for chat; natural EOS stops well before this
3334
MAX_BLOCK_SIZE = 16
3435

@@ -56,7 +57,8 @@ class Preset:
5657
description: str
5758
command_templates: Tuple[Tuple[str, ...], ...]
5859
timeout_minutes: int
59-
# name -> (kind, default). kind ∈ {"int:n_samples", "int:max_new_tokens",
60+
# name -> (kind, default). kind ∈ {"int:n_samples", "int:rtt_samples",
61+
# "int:max_new_tokens",
6062
# "int:block_size", "path:tests"}; None default = required.
6163
params: Mapping[str, Tuple[str, Optional[str]]] = field(default_factory=dict)
6264
# Run the K3 evidence gate over results/research after the commands.
@@ -998,6 +1000,7 @@ def _validate_param(name: str, kind: str, raw: str) -> str:
9981000
raise ManifestError(f"param {name}={raw!r} is not an integer")
9991001
bound = {
10001002
"int:n_samples": MAX_N_SAMPLES,
1003+
"int:rtt_samples": MAX_RTT_SAMPLES,
10011004
"int:max_new_tokens": MAX_NEW_TOKENS,
10021005
"int:block_size": MAX_BLOCK_SIZE,
10031006
}[kind]

0 commit comments

Comments
 (0)