refactor: clean up all code to best readability standards#20
Closed
kRxZykRxZy wants to merge 1 commit into
Closed
Conversation
- Fix SQL injection vulnerability in database.py (column whitelist) - Fix async bug in blockbits.py (get_response called without await) - Fix ZeroDivisionError in project_commands.py when views == 0 - Switch requests.post to aiohttp in experimental_commands.py - Fix missing private/ prefix in remove_line_by_index call - Replace print() with logging across codebase - Replace type() == with isinstance() for type checks - Rename shadowed id variables to project_id/studio_id/topic_id - Extract _extract_project_id/_extract_id helper functions - Add type hints and return annotations throughout - Remove unused imports (scratchattach, time, traceback, etc.) - Use dotenv for token loading instead of reading files - Simplify nested logic in search/user commands - Auto-format all files with ruff
Collaborator
Author
|
why am i jonny garret in commits... also, please dont instant merge, it can have vulnerabilites and errors, ill test it here and maybe you can do some testing if you want then maybe push to main soon. |
Owner
|
Nice, I see plenty of interesting changes! I also see a few things I'd like to revert before merging, so I'm closing the pull request but keeping the branch open to contribute to it. Thanks for doing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a bit of help from OpenCode and github copilot, here is the changlog (its just fixes and cleanups etc and proper async execution)