Skip to content

Commit 5d2f73a

Browse files
Merge pull request #1 from FluidNumerics/feature/cleanup
Feature/cleanup
2 parents 836668a + 9d6a5d7 commit 5d2f73a

7 files changed

Lines changed: 737 additions & 89 deletions

File tree

.github/workflows/lint.yml

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
name: Lint
2+
3+
on: [push, pull_request]
4+
5+
jobs:
6+
check:
7+
runs-on: ubuntu-latest
8+
steps:
9+
- uses: actions/checkout@v4
10+
- uses: astral-sh/setup-uv@v4
11+
- run: uv lock --check
12+
- run: uv sync --dev
13+
- run: uv run black --check .

.pre-commit-config.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
repos:
2+
- repo: local
3+
hooks:
4+
- id: black
5+
name: black
6+
entry: uv run black
7+
language: system
8+
types: [python]

README.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
# xfer — Scalable S3↔S3 Transfers with rclone, Slurm, and pyxis
1+
# xfer
2+
Scalable S3↔S3 Transfers with rclone, Slurm, and pyxis
23

34
![Xfer source to destination](./graphics/xfer-workflow.png)
45

@@ -113,8 +114,6 @@ uv run xfer run \
113114
--array-concurrency 96 \
114115
--rclone-image rclone/rclone:latest \
115116
--rclone-config ~/.config/rclone/rclone.conf \
116-
--rclone-source-opts "--s3-endpoint https://objects.source.example.com" \
117-
--rclone-dest-opts "--s3-endpoint https://objects.dest.example.com" \
118117
--rclone-flags "--transfers 48 --checkers 96 --fast-list --stats 30s" \
119118
--partition transfer \
120119
--cpus-per-task 4 \
@@ -195,9 +194,7 @@ uv run xfer slurm render \
195194
--cpus-per-task 4 \
196195
--mem 8G \
197196
--rclone-image rclone/rclone:latest \
198-
--rclone-config ~/.config/rclone/rclone.conf \
199-
--rclone-source-opts "--s3-endpoint https://objects.source.example.com" \
200-
--rclone-dest-opts "--s3-endpoint https://objects.dest.example.com"
197+
--rclone-config ~/.config/rclone/rclone.conf
201198
```
202199

203200
---
@@ -319,3 +316,12 @@ run/
319316
* **rclone handles object-level idempotency**
320317
* **Slurm handles node-level failures**
321318
* **xfer handles orchestration only**
319+
320+
321+
## Contributing
322+
* To enable pre-commit `black` formatting, run `uv run pre-commit install`
323+
* If necessary, you can format locally with `uv run black .`
324+
* Name branches as either:
325+
* `<your name>/<branch name>` (e.g., `alice/update-readme`)
326+
* `<type of contribution>/<branch name>` (e.g., `feature/claude-integration`) (these are usually `feature`, `patch`, or `docs`)
327+
* Do NOT squash PRs into a single commit

pyproject.toml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,9 @@ target-version = "py310"
2626
[tool.ruff.lint]
2727
select = ["E", "F", "I", "B", "UP"]
2828

29+
[dependency-groups]
30+
dev = [
31+
"black>=26.1.0",
32+
"pre-commit>=4.5.1",
33+
]
34+

0 commit comments

Comments
 (0)