Skip to content

Fix Julia 1.12 compatibility for MethodList API change #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cstjean merged 2 commits into from
Dec 29, 2025
+11 −1
Merged

Fix Julia 1.12 compatibility for MethodList API change #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d396e7
Fix Julia 1.12 compatibility for MethodList API change
ChrisRackauckas Dec 29, 2025
6990d34
Add test for prettify function resolution
ChrisRackauckas Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,11 @@ function makeif(clauses, els = nothing)
end

unresolve1(x) = x
unresolve1(f::Function) = methods(f).mt.name
@static if VERSION >= v"1.12-"
unresolve1(f::Function) = nameof(f)
else
unresolve1(f::Function) = methods(f).mt.name
end

unresolve(ex) = prewalk(unresolve1, ex)

Expand Down
6 changes: 6 additions & 0 deletions test/utils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,12 @@ end
@test flatten(quote begin; begin; f(); g(); end; begin; h(); end; f(); end; end) |> striplines == quote f(); g(); h(); f() end |> striplines
end

@testset "prettify" begin
# Test that prettify resolves function references to their names
@test MacroTools.prettify(:($sin(2))) == :(sin(2))
@test MacroTools.prettify(:($cos(x))) == :(cos(x))
end

@testset "flatten try" begin # see julia#50710 and MacroTools#194 # only tests that do not include `else` -- for the full set of tests see flatten_try.jl
exs = [
quote try; f(); catch; end; end,
Expand Down
Loading