Fix the album art stuff, now it works fully

Author: nift4

app/src/main/java/org/akanework/gramophone/logic/GramophoneAlbumArtProvider.kt

@@ -19,6 +19,9 @@ import android.os.OperationCanceledException
 import android.os.ParcelFileDescriptor
 import android.os.ProxyFileDescriptorCallback
 import android.os.storage.StorageManager
+import android.system.ErrnoException
+import android.system.Os
+import android.system.OsConstants.SEEK_SET
 import android.util.Log
 import androidx.core.content.getSystemService
 import androidx.core.os.BundleCompat
@@ -161,10 +164,19 @@ class GramophoneAlbumArtProvider : ContentProvider() {
                                         })
                         ) {
                             (result.source.metadata as ContentMetadata).assetFileDescriptor.let {
-                                cfd.complete(AssetFileDescriptor(it
-                                    .parcelFileDescriptor.dup(), it.startOffset, it.declaredLength))
+                                val newFd = it.parcelFileDescriptor.dup()
+                                try {
+                                    // It's only safe to give the unmodified fd to reader if it is
+                                    // seekable, because otherwise (pipe?) no matter when we dup, we
+                                    // would eat some data when checking for JPEG header.
+                                    Os.lseek(newFd.fileDescriptor, it.startOffset,
+                                        SEEK_SET)
+                                    cfd.complete(AssetFileDescriptor(newFd, it.startOffset,
+                                        it.declaredLength))
+                                } catch (_: ErrnoException) {}
                             }
-                        } else {
+                        }
+                        if (!cfd.isCompleted) {
                             writeDataCommon(cfd, scope, options.context) {
                                 if (it != null) {
                                     it.sink().buffer().writeAll(src); null

app/src/main/java/org/akanework/gramophone/logic/utils/CoilArtPipeline.kt

@@ -12,6 +12,7 @@ import android.os.CancellationSignal
 import android.os.Environment
 import android.os.OperationCanceledException
 import android.provider.MediaStore
+import androidx.media3.common.util.Log
 import coil3.ImageLoader
 import coil3.Uri
 import coil3.decode.ContentMetadata
@@ -100,7 +101,7 @@ object CoilArtPipeline {
                     throw IllegalArgumentException("Bad data $data")
                 val imgUri = MediaStoreCompat.getMediaUriForFile(options.context,
                     imgFile.absolutePath)
-                val data = if (isSmallSize(options.context, options.size) && false) // TODO(ASAP)
+                val data = if (isSmallSize(options.context, options.size))
                     LoadThumbnailData(imgUri)
                 else
                     imgUri
@@ -136,7 +137,7 @@ object CoilArtPipeline {
         override fun map(data: Uri, options: Options): LoadThumbnailData? {
             return if (data.scheme == ContentResolver.SCHEME_CONTENT &&
                 data.authority == GramophoneAlbumArtProvider.PROVIDER_AUTHORITY &&
-                data.pathSegments.first() == "song" && false && // TODO(ASAP)
+                data.pathSegments.first() == "song" &&
                 isSmallSize(options.context, options.size)) {
                 LoadThumbnailData(ContentUris.withAppendedId(
                     MediaStore.Audio.Media.EXTERNAL_CONTENT_URI,