Update linter config (#75)

Author: FollowTheProcess

.golangci.yml

@@ -36,6 +36,7 @@ linters:
     - nestif # cyclop does this
     - nlreturn # Similar to wsl, I think best left to judgement
     - nonamedreturns # Named returns are often helpful, it's naked returns that are the issue
+    - noinlineerr # This is more readable in some cases
     - paralleltest # I've never had Go tests take longer than a few seconds, it's fine
     - thelper # Everything in here is a helper basically
     - unparam # gopls is better and more subtle
@@ -54,7 +55,7 @@ linters:
         linters:
           - prealloc # These kinds of optimisations will make no difference to test code
           - gosec # Tests don't need security stuff
-          - goconst
+          - goconst # Nah
 
     paths:
       - internal/diff
@@ -161,6 +162,7 @@ linters:
             - fmt\.(Fp|P)rint(ln|f)?
             - strings.Builder.Write(String|Byte)?
             - bytes.Buffer.Write(String|Byte)?
+            - os.File.Close?
 
         - name: flag-parameter
           disabled: true # As far as I can work out this just doesn't like bools

Taskfile.yml

@@ -9,6 +9,7 @@ tasks:
   default:
     desc: List all available tasks
     silent: true
+    internal: true
     cmds:
       - task --list
 
@@ -25,18 +26,17 @@ tasks:
     desc: Run go fmt on all source files
     sources:
       - "**/*.go"
-    preconditions:
-      - sh: command -v golines
-        msg: golines not installed, run `go install github.com/segmentio/golines@latest`
+      - .golangci.yml
     cmds:
-      - go fmt ./...
-      - golines . --ignore-generated --write-output --max-len 120
+      - golangci-lint fmt
 
   test:
     desc: Run the test suite
     sources:
       - "**/*.go"
-      - testdata/**/*.snap.txt
+      - go.mod
+      - go.sum
+      - "**/testdata/**/*"
     cmds:
       - go test -race ./... {{ .CLI_ARGS }}
 
@@ -52,8 +52,6 @@ tasks:
     sources:
       - "**/*.go"
       - .golangci.yml
-    deps:
-      - fmt
     preconditions:
       - sh: command -v golangci-lint
         msg: golangci-lint not installed, see https://golangci-lint.run/usage/install/#local-installation

test.go

@@ -446,6 +446,7 @@ func CaptureOutput(tb testing.TB, fn func() error) (stdout, stderr string) {
 		if _, err := io.Copy(buf, stdoutReader); err != nil {
 			tb.Fatalf("CaptureOutput: failed to copy from stdout reader: %v", err)
 		}
+
 		stdoutCapture <- buf.String()
 	}(&wg)
 
@@ -459,6 +460,7 @@ func CaptureOutput(tb testing.TB, fn func() error) (stdout, stderr string) {
 		if _, err := io.Copy(buf, stderrReader); err != nil {
 			tb.Fatalf("CaptureOutput: failed to copy from stderr reader: %v", err)
 		}
+
 		stderrCapture <- buf.String()
 	}(&wg)
 

test_test.go

@@ -14,12 +14,16 @@ import (
 	"go.followtheprocess.codes/test"
 )
 
-var update = flag.Bool("update", false, "Update snapshots")
+var (
+	update = flag.Bool("update", false, "Update snapshots")
+	clean  = flag.Bool("clean", false, "Erase all snapshots and recreate them from scratch")
+)
 
 // TB is a fake implementation of [testing.TB] that simply records in internal
 // state whether or not it would have failed and what it would have written.
 type TB struct {
 	testing.TB
+
 	out    io.Writer
 	failed bool
 }
@@ -434,7 +438,7 @@ func TestTest(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			buf := &bytes.Buffer{}
 			tb := &TB{out: buf}
-			snap := snapshot.New(t, snapshot.Update(*update), snapshot.Color(false))
+			snap := snapshot.New(t, snapshot.Update(*update), snapshot.Clean(*clean), snapshot.Color(false))
 
 			if tb.failed {
 				t.Fatalf("%s initial failed state should be false", tt.name)