(#359) WofBrushFactory: make everything private and readonly

Author: ForNeVeR

CHANGELOG.md

@@ -14,7 +14,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
   - .NET Framework 4.6.2 or later,
   - .NET 6.0 and later.
 - **(Breaking change.)** `WpfMath.Colors.IColorParser::Parse` now accepts `IReadOnlyList` instead of `IEnumerable`.
-- **(Minor breaking change.)** `XamlMath.Colors.StandardColorParsers::Dictionary` public field is now `readonly`.
+- **(Minor breaking change.)** `XamlMath.Colors.StandardColorParsers::Dictionary` static public field is now `readonly`.
+- **(Minor breaking change.)** `WpfMath.Rendering.WpfBrushFactory`'s constructor is now `private`.
+- **(Minor breaking change.)** `WpfMath.Rendering.WpfBrushFactory::Instance` static public field is now `readonly`.
 
 ### Removed
 - **(Breaking change.)** Delete the `TexRenderer` class. Use extension methods from `WpfMath.Rendering.WpfTeXFormulaExtensions` and `WpfMath.Rendering.TeXFormulaExtensions` to replace its functionality in your code.

api/WpfMath.net462.verified.cs

@@ -122,8 +122,8 @@ public static partial class WpfBrushExtensions
     }
     public partial class WpfBrushFactory : XamlMath.Rendering.IBrushFactory
     {
-        public static WpfMath.Rendering.WpfBrushFactory Instance;
-        public WpfBrushFactory() { }
+        internal WpfBrushFactory() { }
+        public static readonly WpfMath.Rendering.WpfBrushFactory Instance;
         public XamlMath.Rendering.IBrush FromColor(XamlMath.Colors.RgbaColor color) { throw null; }
     }
     public static partial class WpfTeXEnvironment

api/WpfMath.net6.0.verified.cs

@@ -124,8 +124,8 @@ public static partial class WpfBrushExtensions
     }
     public partial class WpfBrushFactory : XamlMath.Rendering.IBrushFactory
     {
-        public static WpfMath.Rendering.WpfBrushFactory Instance;
-        public WpfBrushFactory() { }
+        internal WpfBrushFactory() { }
+        public static readonly WpfMath.Rendering.WpfBrushFactory Instance;
         public XamlMath.Rendering.IBrush FromColor(XamlMath.Colors.RgbaColor color) { throw null; }
     }
     public static partial class WpfTeXEnvironment

api/XamlMath.Shared.net462.verified.cs

@@ -246,7 +246,7 @@ public partial struct RgbaColor : System.IEquatable<XamlMath.Colors.RgbaColor>
     }
     public static partial class StandardColorParsers
     {
-        public static System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
+        public static readonly System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
     }
 }
 namespace XamlMath.Exceptions

api/XamlMath.Shared.net6.0.verified.cs

@@ -246,7 +246,7 @@ public partial struct RgbaColor : System.IEquatable<XamlMath.Colors.RgbaColor>
     }
     public static partial class StandardColorParsers
     {
-        public static System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
+        public static readonly System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
     }
 }
 namespace XamlMath.Exceptions

api/XamlMath.Shared.netstandard2.0.verified.cs

@@ -246,7 +246,7 @@ public partial struct RgbaColor : System.IEquatable<XamlMath.Colors.RgbaColor>
     }
     public static partial class StandardColorParsers
     {
-        public static System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
+        public static readonly System.Collections.Generic.IReadOnlyDictionary<string, XamlMath.Colors.IColorParser> Dictionary;
     }
 }
 namespace XamlMath.Exceptions

src/WpfMath/Rendering/WpfBrush.cs

@@ -15,9 +15,10 @@ private WpfBrush(Brush brush) : base(brush)
 
 public class WpfBrushFactory : IBrushFactory
 {
-    // TODO[#359]: private constructor
-    // TODO[#359]: readonly property instead of a writeable field
-    public static WpfBrushFactory Instance = new();
+    public static readonly WpfBrushFactory Instance = new();
+
+    private WpfBrushFactory() {}
+
     public IBrush FromColor(RgbaColor color) =>
         new SolidColorBrush(
             Color.FromArgb(color.A, color.R, color.G, color.B)).ToPlatform();