Skip to content

fix: add isSortable to SmartFieldOptions type#914

Open
gventuri wants to merge 1 commit intoForestAdmin:mainfrom
gventuri:main
Open

fix: add isSortable to SmartFieldOptions type#914
gventuri wants to merge 1 commit intoForestAdmin:mainfrom
gventuri:main

Conversation

@gventuri
Copy link
Copy Markdown

Definition of Done

I added isSortable to type SmartFieldOptions. It is a valid param for a field, and should be accepted by typescript (check it out here: https://github.com/ForestAdmin/forest-express/blob/main/src/services/apimap-fields-formater.js).

General

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes mad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant