SDKS-5096: Enhance WebAuthn registration by adding optional device name#519
Merged
Conversation
vibhorgoswami
requested review from
george-bafaloukas-forgerock,
rodrigoareis and
spetrov
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #519 +/- ##
==========================================
Coverage 65.75% 65.75%
+ Complexity 1764 1762 -2
==========================================
Files 264 264
Lines 8658 8658
Branches 969 969
==========================================
Hits 5693 5693
Misses 2534 2534
Partials 431 431
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
witrisna
previously approved these changes
Jun 3, 2026
george-bafaloukas-forgerock
previously approved these changes
Jun 4, 2026
george-bafaloukas-forgerock
left a comment
george-bafaloukas-forgerock
left a comment
Contributor
There was a problem hiding this comment.
LGTM
rodrigoareis
requested changes
Jun 4, 2026
rodrigoareis
left a comment
rodrigoareis
left a comment
Contributor
There was a problem hiding this comment.
Overall changes looks good. Left minor comments
spetrov
added a commit
that referenced
this pull request
Jun 16, 2026
* SDKS-4658: Set code verifier to null for Apple Sign-In The `codeVerifier` is explicitly set to `null` in the `AuthorizationRequest.Builder` for the Apple Sign-In handler. * SDKS-4714: Use empty request body in self-service session endpoint (#510) * SDKS-4714: Use empty request body in self-service session endpoint Remove the `EMPTY` constant from OkHttp's `RequestBody` and has been replaced with `"".toRequestBody()`. * Update Session.kt Signed-off-by: Andy Witrisna <andy.witrisna@forgerock.com> --------- Signed-off-by: Andy Witrisna <andy.witrisna@forgerock.com> * Add migration support for Ping SDK with DefaultStorageClient (#511) * Increase sleep time in FRUserMockTest to ensure token expiration (#513) The `Thread.sleep` duration in `FRUserMockTest.kt` is increased from 1000ms to 2000ms to allow sufficient time for tokens to expire before testing the refresh token flow. * ForgeRock Android SDK 4.8.4 Release preparation (#512) * Updated for the ForgeRock 4.8.4 release * Fixed various e2e test cases. * SDKS-4947 Updating README with maintenance information (#515) * Updating README with maintenance information * Rename contribution file name * SDKS-5037 - Upgrade bcpkix-jdk18on from 1.81 to 1.84 to address CVE-2026-5588 (#516) * ForgeRock Android SDK 4.8.5 Release preparation (#517) * Removed Sonatype OSS Index Scan from the CI (this service has been discontinued) * Updated version number for the ForgeRock 4.8.5 release * Fix mend tasks to fail the pipeline if critical or high vulnerabilities are found * SDKS-5096: Enhance WebAuthn registration by adding optional device name (#519) * SDKS-5096: Enhance WebAuthn registration by adding optional device name parameter * SDKS-5120: Add authenticationValidityDuration support to device binding and signing (#520) * SDKS-5120: Allow configurable authenticationValidityDuration in DeviceBindingCallback and DeviceSigningVerifierCallback * PR review - guard authentication validity duration. * [fix] SDKS-5114 Handle AM 400 for Push Number Challenge with distinct exception (#521) * [fix] SDKS-5114 Handle AM 400 for Push Number Challenge with distinct exception AM 8.1.0 (OPENAM-24154) returns HTTP 400 when a user selects the wrong number in a Push Number Challenge. Previously the SDK surfaced a generic PushMechanismException with no semantic meaning. This fix introduces PushNumberChallengeException (extends PushMechanismException) so callers can distinguish a wrong-number rejection from other failures, and leaves the PushNotification in its pending state so the app can offer a retry. Phases: - phase 1: Create PushNumberChallengeException (8804d77c) - phase 2: Handle 400 for Push Number Challenge in PushResponder (fe17bf07) - phase 3: Unit tests for 400 number-challenge path (4d57f2ca) - code review: Remove body logging, fix test builder placement (cc910478) Refs: SDKS-5114 * Addressing comment from Stoyan * Updated version number for the ForgeRock 4.8.6 release (#522) --------- Signed-off-by: Andy Witrisna <andy.witrisna@forgerock.com> Co-authored-by: Andy Witrisna <witrisna@gmail.com> Co-authored-by: Andy Witrisna <andy.witrisna@forgerock.com> Co-authored-by: Vibhor Goswami <vibhor.goswami@gmail.com> Co-authored-by: Rodrigo Reis <rodrigo.reis@forgerock.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
SDKS-5096
Description
This PR fixes the bug raised for omitting the device name supplied by the caller. The device name is now being added as part of the json response.
Definition of Done Checklist: