Skip to content

SDKS-3821: Update copyright#539

Merged
ancheetah merged 1 commit into
developfrom
SDKS-3821-copyright
Apr 30, 2025
Merged

SDKS-3821: Update copyright#539
ancheetah merged 1 commit into
developfrom
SDKS-3821-copyright

Conversation

@ancheetah
Copy link
Copy Markdown
Contributor

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-3821

Description

Updated copyright verbiage from Forgerock to Ping Identity Corporation. Updated LICENSE files. Added copyright to files missing it.

No changeset.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 28, 2025

⚠️ No Changeset found

Latest commit: 5652001

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 28, 2025

View your CI Pipeline Execution ↗ for commit 5652001.

Command Status Duration Result
nx affected -t build lint test docs e2e-ci --ve... ✅ Succeeded 4m 13s View ↗
nx-cloud record -- nx format:check --verbose ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-30 17:22:58 UTC

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2025

Codecov Report

Attention: Patch coverage is 78.10458% with 67 lines in your changes missing coverage. Please review.

Project coverage is 58.68%. Comparing base (4d7b839) to head (5652001).

Files with missing lines Patch % Lines
...es/javascript-sdk/src/device-client/types/index.ts 0.00% 10 Missing ⚠️
packages/token-vault/src/index.ts 0.00% 9 Missing ⚠️
packages/token-vault/src/lib/client.ts 0.00% 9 Missing ⚠️
packages/token-vault/src/lib/proxy.ts 0.00% 9 Missing ⚠️
packages/token-vault/src/lib/types/config.types.ts 0.00% 9 Missing ⚠️
packages/token-vault/src/lib/types/index.ts 0.00% 9 Missing ⚠️
packages/token-vault/src/lib/worker/index.ts 0.00% 9 Missing ⚠️
...ript-sdk/src/fr-device/device-profile.mock.data.ts 0.00% 1 Missing ⚠️
...kages/javascript-sdk/src/fr-webauthn/interfaces.ts 0.00% 1 Missing ⚠️
...ages/javascript-sdk/src/token-storage/constants.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #539      +/-   ##
===========================================
+ Coverage    58.57%   58.68%   +0.10%     
===========================================
  Files          105      105              
  Lines        25461    25681     +220     
  Branches      1690     1690              
===========================================
+ Hits         14915    15071     +156     
- Misses       10546    10610      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, but we are supposed to use spaces between the years:

2020 - 2025

Copy link
Copy Markdown
Contributor

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I'm not sure if the spaces between the dash are important, but everything else looks good.

@ancheetah ancheetah force-pushed the SDKS-3821-copyright branch from a8f65d8 to 5652001 Compare April 30, 2025 17:17
Copy link
Copy Markdown

@rodrigoareis rodrigoareis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ancheetah ancheetah merged commit bdbf007 into develop Apr 30, 2025
4 checks passed
@ancheetah ancheetah deleted the SDKS-3821-copyright branch April 30, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants