fix(journey): use Device from journey-client instead of FRDevice

Author: vatsalparikh

core/journey/callbacks/_utilities/callback.utilities.ts

@@ -15,7 +15,6 @@ import type {
 } from '@forgerock/journey-client/types';
 
 import { interpolate } from '$core/_utilities/i18n.utilities';
-import type { PolicyParams } from '@forgerock/javascript-sdk/src/auth/interfaces';
 
 /** *********************************************
  * INTERFACES AND TYPES
@@ -27,7 +26,8 @@ export interface Policy {
   params: Record<string, unknown>;
 }
 export interface FailedPolicy {
-  params: Partial<PolicyParams> | undefined;
+  // TODO: PolicyParams must be re-exported by journey-client from forgerock/sdk-types, until then we derive the type like below
+  params: PolicyRequirement['params'];
   policyRequirement: string;
   restructured: RestructuredParam[];
 }

core/journey/callbacks/device-profile/device-profile.stories.js

@@ -9,7 +9,7 @@
 
 import { expect } from 'storybook/test';
 import { callbackType } from '@forgerock/journey-client';
-import { FRDevice } from '@forgerock/javascript-sdk';
+import { Device } from '@forgerock/journey-client/device';
 import { createJourneyStep } from '$journey/_utilities/step.mock';
 import { deviceProfileMockNoMessage, deviceProfileMockMessage } from './device-profile.mock';
 import DeviceProfile from './device-profile.story.svelte';
@@ -49,7 +49,7 @@ export const Interaction = {
   },
   play: async ({ canvasElement }) => {
     const canvas = within(canvasElement);
-    const device = new FRDevice({});
+    const device = new Device({});
     const cb = stepWithMessage.getCallbackOfType(callbackType.DeviceProfileCallback);
 
     const msg = canvas.getByText('This is a message');

core/journey/callbacks/device-profile/device-profile.story.svelte

@@ -8,7 +8,6 @@
  -->
 
 <script lang="ts">
-  import { Config } from '@forgerock/javascript-sdk';
   import type { DeviceProfileCallback } from '@forgerock/journey-client/types';
 
   import Centered from '$components/primitives/box/centered.svelte';
@@ -21,9 +20,6 @@
   export let callbackMetadata: Maybe<CallbackMetadata>;
   export let selfSubmitFunction: () => void;
 
-  // Now required due to logger utility
-  Config.set({ serverConfig: { baseUrl: 'https://example.com/am/' } });
-
   let mergedCallbackMetadata = {
     derived: {
       canForceUserInputOptionality: false,

core/journey/callbacks/device-profile/device-profile.svelte

@@ -8,8 +8,9 @@
  -->
 
 <script lang="ts">
-  import { FRDevice } from '@forgerock/javascript-sdk';
+  import { Device } from '@forgerock/journey-client/device';
   import type { DeviceProfileCallback } from '@forgerock/journey-client/types';
+
   import Spinner from '$components/primitives/spinner/spinner.svelte';
   import Text from '$components/primitives/text/text.svelte';
   import type {
@@ -23,7 +24,7 @@
   export let callbackMetadata: Maybe<CallbackMetadata> = null;
   export let stepMetadata: Maybe<StepMetadata> = null;
   export let selfSubmitFunction: SelfSubmitFunction;
-  const device = new FRDevice({});
+  const device = new Device({});
   let deviceMessage = (callback as DeviceProfileCallback).getMessage();
   async function initializeProfile() {
     const location = callback?.isLocationRequired() ?? false;

core/journey/stages/stages.story.svelte

@@ -8,7 +8,6 @@
  -->
 
 <script lang="ts">
-  import { Config } from '@forgerock/javascript-sdk';
   import type { JourneyStep } from '@forgerock/journey-client/types';
   import type { z } from 'zod';
 
@@ -34,9 +33,6 @@
   export let step: JourneyStep;
   export let style: z.infer<typeof partialStyleSchema>;
 
-  // Now required due to logger utility
-  Config.set({ serverConfig: { baseUrl: 'https://example.com/am/' } });
-
   let stageName;
   let stageJson;