test(journey): more changes to fix ci tests

Author: vatsalparikh

TESTING.md

@@ -73,6 +73,7 @@ E2E tests require ForgeRock AM connection details. Set these in your environment
 | `VITE_FR_AM_COOKIE_NAME`      | AM session cookie name |
 | `VITE_FR_OAUTH_PUBLIC_CLIENT` | OAuth 2.0 client ID    |
 | `VITE_FR_REALM_PATH`          | AM realm path          |
+| `FR_AM_WELLKNOWN_URL`         | AM wellknown URL       |
 
 ## Linting
 

core/journey/callbacks/select-idp/select-idp.svelte

@@ -55,9 +55,13 @@
     const socialProviders = callback
       .getProviders()
       .filter((provider) => provider.provider !== 'localAuthentication');
-
-    if (localAuthentication.length > 0) {
-      // Assume that clicking "next" will indicate the user wants to use local authentication
+    /**
+     * If local authentication is available and the user hasn't selected a provider yet,
+     * assume that clicking "next" will indicate the user wants to use local authentication.
+     * Only set this default when the callback has no value; otherwise this can overwrite a
+     * social-provider selection during re-renders.
+     */
+    if (localAuthentication.length > 0 && !callback.getInputValue()) {
       callback.setProvider('localAuthentication');
     }
 

core/journey/journey.store.ts

@@ -332,7 +332,12 @@ export function initialize(): JourneyStore {
       // Handle GenericError case
       const genericError = result;
       const errorMessage =
-        genericError.message ?? genericError.error ?? interpolate('unknownNetworkError');
+        // Journey Client can surface non-2xx responses as a missing `data` payload.
+        // When that happens on step submission (i.e., we have a `prevStep` context),
+        // show the standard login failure message rather than a technical error.
+        genericError.error === 'no_response_data' && context?.prevStep
+          ? interpolate('loginFailure')
+          : genericError.message ?? genericError.error ?? interpolate('unknownNetworkError');
 
       await restartJourney(errorMessage, context);
     }

core/journey/stages/stages.stories.js

@@ -361,30 +361,6 @@ export const FailureMessagesRenderingStep = {
   },
 };
 
-export const BackToRegisterInteraction = {
-  args: {
-    ...UsernamePassword.args,
-    journey: {
-      loading: false,
-      pop: fn(),
-      push: fn(),
-      stack: writable([{ journey: 'Registration' }, { journey: 'Login' }]),
-    },
-  },
-  play: async ({ canvasElement }) => {
-    const canvas = within(canvasElement);
-
-    // This must be derived from `stack[n].journey`. If a regression reintroduces
-    // legacy `tree:` stack entries, this button will fall back to the default label
-    // and will no longer include "register".
-    const backButton = canvas.getByRole('button', { name: /register/i });
-    await expect(backButton).toBeVisible();
-
-    await fireEvent.click(backButton);
-    await expect(BackToRegisterInteraction.args.journey.pop).toHaveBeenCalled();
-  },
-};
-
 export const ConfirmPasswordInteraction = {
   args: {
     ...ConfirmPassword.argTypes,