fix(mfa-step): create a new step for handling MFA set up page text output callback script#489
Merged
Conversation
🦋 Changeset detectedLatest commit: 9ba8b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d3ec6f6 to
0c0887e
Compare
SteinGabriel
requested changes
May 6, 2026
bc799f0 to
ad2a3e0
Compare
SteinGabriel
reviewed
May 7, 2026
1bfbb02 to
e16d505
Compare
ryanbas21
reviewed
May 11, 2026
cerebrl
requested changes
May 12, 2026
Contributor
cerebrl
left a comment
There was a problem hiding this comment.
This looks good, other than the condition I commented on.
3e2e2ad to
2986214
Compare
cerebrl
approved these changes
May 12, 2026
SteinGabriel
approved these changes
May 13, 2026
Contributor
SteinGabriel
left a comment
There was a problem hiding this comment.
The changes look good and work as expected.
It seems like a changeset is needed, but other than that it looks ready to merge.
…tput callback script
Contributor
Author
Added changeset, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-4918
Description
This PR addresses scripted nodes for MFA during 2FA registration process. More details in the ticket
Reasoning
How to test
Recording
Before changes
https://github.com/user-attachments/assets/e8bdfecd-2eba-472d-80fe-8ab272ffa85b
After changes
https://github.com/user-attachments/assets/e13e6eb4-91e9-451f-ad89-d297ee002dc5
+error.svelte file
I forgot to push the +error.svelte file from Gabriel's comment in journey client PR. Since it's a generic error file I have attached it in this PR.
#468 (comment)