SDKS-4924 Add Logger to FIDO module #156
Open
george-bafaloukas-forgerock wants to merge 2 commits into
Open
Conversation
Address review of bb429bc: - Replace `Fido.logger` stored property with a `logger:` parameter on `register` and `authenticate`. Eliminates the singleton-mutation race where two concurrent ceremonies (DaVinci + Journey, or two DaVincis) would clobber each other's logger. - Drop the four `fido.logger = logger` propagation lines; pass the workflow logger through the call directly. - Cover the four propagation paths in FidoLoggerTests by capturing the `logger:` argument on `MockFido` and asserting it matches the workflow config logger. - Link `PingDavinci.framework` into the test target so the DaVinci propagation tests can construct a real `DaVinci` instance. - Document FIDO single-flight semantics on the class doc comment. - Add CHANGELOG `[Unreleased]` entry. - Add Mocks.swift copyright header. - `.gitignore` agent / planning artefacts and merge / Finder leftovers.
george-bafaloukas-forgerock
requested review from
rodrigoareis,
spetrov and
vahancouver
and removed request for
rodrigoareis and
spetrov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Ticket
JIRA "Add Logger to FIDO module "
Description
PingLoggeras a direct SPM dependency ofPingFido(the.podspecalready declared it; this brings SPM into parity).logger:parameter toFido.registerandFido.authenticate. Per-call parameter (not a stored property) so concurrent ceremonies on the sharedFido.sharedinstance do not clobber each other's logger.FidoRegistrationCollector,FidoAuthenticationCollector,FidoRegistrationCallback,FidoAuthenticationCallback) pass their workflow logger (davinci?.config.logger/journey?.config.logger) intoFidoso registration/authentication state transitions and errors emit through the same logger as the surrounding flow.Checklist: