-
Notifications
You must be signed in to change notification settings - Fork 3
Expand file tree
/
Copy pathclient.store.test.ts
More file actions
506 lines (434 loc) · 18.4 KB
/
client.store.test.ts
File metadata and controls
506 lines (434 loc) · 18.4 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
/*
* Copyright (c) 2025 Ping Identity Corporation. All rights reserved.
*
* This software may be modified and distributed under the terms
* of the MIT license. See the LICENSE file for details.
*/
import { callbackType } from '@forgerock/sdk-types';
import { afterEach, describe, expect, test, vi } from 'vitest';
import type { GenericError, Step, WellknownResponse } from '@forgerock/sdk-types';
import { journey } from './client.store.js';
import { createJourneyStep } from './step.utils.js';
import { JourneyClientConfig } from './config.types.js';
/**
* Type guard to check if a result is a GenericError
*/
function isGenericError(result: unknown): result is GenericError {
return typeof result === 'object' && result !== null && 'error' in result && 'type' in result;
}
// Create a singleton mock instance for storage
const mockStorageInstance = {
get: vi.fn(),
set: vi.fn(),
remove: vi.fn(),
};
// Mock dependencies with side effects
vi.mock('@forgerock/storage', () => ({
createStorage: vi.fn(() => mockStorageInstance),
}));
vi.mock('./device/device-profile.js', () => ({
default: vi.fn(() => ({
getProfile: vi.fn().mockResolvedValue({}),
})),
}));
// Mock the fetch API to control responses
const mockFetch = vi.fn();
global.fetch = mockFetch;
// Wellknown-based config (new pattern)
const mockWellknownUrl = 'https://test.com/am/oauth2/realms/root/.well-known/openid-configuration';
const mockWellknownResponse: WellknownResponse = {
issuer: 'https://test.com/am/oauth2/realms/root',
authorization_endpoint: 'https://test.com/am/oauth2/realms/root/authorize',
token_endpoint: 'https://test.com/am/oauth2/realms/root/access_token',
userinfo_endpoint: 'https://test.com/am/oauth2/realms/root/userinfo',
jwks_uri: 'https://test.com/am/oauth2/realms/root/connect/jwk_uri',
end_session_endpoint: 'https://test.com/am/oauth2/realms/root/connect/endSession',
revocation_endpoint: 'https://test.com/am/oauth2/realms/root/token/revoke',
introspection_endpoint: 'https://test.com/am/oauth2/realms/root/introspect',
};
const mockConfig: JourneyClientConfig = {
serverConfig: {
wellknown: mockWellknownUrl,
},
};
/**
* Extracts URL from fetch input (handles both string URLs and Request objects).
*/
function getUrlFromInput(input: RequestInfo | URL): string {
if (typeof input === 'string') return input;
if (input instanceof Request) return input.url;
return input.toString();
}
/**
* Helper to setup mock fetch for wellknown + journey responses
*/
function setupMockFetch(journeyResponse: Step | null = null) {
mockFetch.mockImplementation((input: RequestInfo | URL) => {
const url = getUrlFromInput(input);
// Wellknown endpoint
if (url.includes('.well-known/openid-configuration')) {
return Promise.resolve(new Response(JSON.stringify(mockWellknownResponse)));
}
// Journey authenticate endpoint
if (journeyResponse && url.includes('/authenticate')) {
return Promise.resolve(new Response(JSON.stringify(journeyResponse)));
}
return Promise.reject(new Error(`Unexpected fetch: ${url}`));
});
}
describe('journey-client', () => {
afterEach(() => {
vi.clearAllMocks();
});
test('journey_WellknownConfig_ReturnsClientWithAllMethods', async () => {
setupMockFetch();
const client = await journey({ config: mockConfig });
expect(client.start).toBeInstanceOf(Function);
expect(client.next).toBeInstanceOf(Function);
expect(client.redirect).toBeInstanceOf(Function);
expect(client.resume).toBeInstanceOf(Function);
expect(client.terminate).toBeInstanceOf(Function);
});
test('journey_InvalidWellknownUrl_ThrowsError', async () => {
const invalidConfig: JourneyClientConfig = {
serverConfig: {
wellknown: 'not-a-valid-url',
},
};
await expect(journey({ config: invalidConfig })).rejects.toThrow('Invalid wellknown URL');
});
test('journey_MissingWellknownPath_ThrowsError', async () => {
const badPathConfig: JourneyClientConfig = {
serverConfig: {
wellknown: 'https://am.example.com/am/oauth2/alpha',
},
};
await expect(journey({ config: badPathConfig })).rejects.toThrow('Invalid wellknown URL');
});
test('start_WellknownConfig_FetchesFirstStep', async () => {
const mockStepResponse: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(mockStepResponse);
const client = await journey({ config: mockConfig });
const step = await client.start();
expect(step).toBeDefined();
expect(isGenericError(step)).toBe(false);
expect(mockFetch).toHaveBeenCalledTimes(2); // wellknown + start
const requests = mockFetch.mock.calls.map((call) =>
getUrlFromInput(call[0] as RequestInfo | URL),
);
expect(requests[0]).toContain('.well-known/openid-configuration');
expect(requests[1]).toBe('https://test.com/am/json/realms/root/authenticate');
expect(step).toHaveProperty('type', 'Step');
if (step && !isGenericError(step)) {
expect(step.payload).toEqual(mockStepResponse);
}
});
test('next_WellknownConfig_SendsStepAndReturnsNext', async () => {
const initialStep = createJourneyStep({
authId: 'test-auth-id',
callbacks: [
{
type: callbackType.NameCallback,
input: [{ name: 'IDToken1', value: 'test-user' }],
output: [],
},
],
});
const nextStepPayload: Step = {
authId: 'test-auth-id',
callbacks: [
{
type: callbackType.PasswordCallback,
input: [{ name: 'IDToken2', value: 'test-password' }],
output: [],
},
],
};
setupMockFetch(nextStepPayload);
const client = await journey({ config: mockConfig });
const nextStep = await client.next(initialStep, {});
expect(nextStep).toBeDefined();
expect(isGenericError(nextStep)).toBe(false);
expect(mockFetch).toHaveBeenCalledTimes(2); // wellknown + next
const request = mockFetch.mock.calls[1][0] as Request;
expect(request.url).toBe('https://test.com/am/json/realms/root/authenticate');
expect(request.method).toBe('POST');
expect(await request.json()).toEqual(initialStep.payload);
expect(nextStep).toHaveProperty('type', 'Step');
if (nextStep && !isGenericError(nextStep)) {
expect(nextStep.payload).toEqual(nextStepPayload);
}
});
test('redirect_WellknownConfig_StoresStepAndCallsLocationAssign', async () => {
const mockStepPayload: Step = {
callbacks: [
{
type: callbackType.RedirectCallback,
input: [],
output: [{ name: 'redirectUrl', value: 'https://sso.com/redirect' }],
},
],
};
const step = createJourneyStep(mockStepPayload);
const assignMock = vi.fn();
const locationSpy = vi.spyOn(window, 'location', 'get').mockReturnValue({
...window.location,
assign: assignMock,
});
setupMockFetch();
const client = await journey({ config: mockConfig });
await client.redirect(step);
expect(mockStorageInstance.set).toHaveBeenCalledWith({ step: step.payload });
expect(assignMock).toHaveBeenCalledWith('https://sso.com/redirect');
locationSpy.mockRestore();
});
describe('resume()', () => {
test('resume_WithPreviousStepInStorage_CallsNextWithUrlParams', async () => {
const previousStepPayload: Step = {
callbacks: [{ type: callbackType.RedirectCallback, input: [], output: [] }],
};
mockStorageInstance.get.mockResolvedValue({ step: previousStepPayload });
const nextStepPayload: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(nextStepPayload);
const client = await journey({ config: mockConfig });
const resumeUrl = 'https://app.com/callback?code=123&state=abc';
const step = await client.resume(resumeUrl, {});
expect(step).toBeDefined();
expect(mockStorageInstance.get).toHaveBeenCalledTimes(1);
expect(mockStorageInstance.remove).toHaveBeenCalledTimes(1);
expect(mockFetch).toHaveBeenCalledTimes(2); // wellknown + next
const request = mockFetch.mock.calls[1][0] as Request;
const url = new URL(request.url);
expect(url.origin + url.pathname).toBe('https://test.com/am/json/realms/root/authenticate');
expect(url.searchParams.get('code')).toBe('123');
expect(url.searchParams.get('state')).toBe('abc');
expect(request.method).toBe('POST');
expect(await request.json()).toEqual(previousStepPayload);
expect(step).toHaveProperty('type', 'Step');
if (step && !isGenericError(step)) {
expect(step.payload).toEqual(nextStepPayload);
}
});
test('resume_WithPreviousStepInStorage_ForwardsLegacyUrlParams', async () => {
const previousStepPayload: Step = {
callbacks: [{ type: callbackType.RedirectCallback, input: [], output: [] }],
};
mockStorageInstance.get.mockResolvedValue({ step: previousStepPayload });
const nextStepPayload: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(nextStepPayload);
const client = await journey({ config: mockConfig });
const resumeUrl =
'https://app.com/callback?code=123&state=abc&error=access_denied&errorCode=E1&errorMessage=oops&form_post_entry=fp&nonce=n1&RelayState=rs&responsekey=rk&scope=openid&suspendedId=s1';
await client.resume(resumeUrl, {});
const request = mockFetch.mock.calls[1][0] as Request;
const url = new URL(request.url);
expect(url.searchParams.get('code')).toBe('123');
expect(url.searchParams.get('state')).toBe('abc');
expect(url.searchParams.get('error')).toBe('access_denied');
expect(url.searchParams.get('errorCode')).toBe('E1');
expect(url.searchParams.get('errorMessage')).toBe('oops');
expect(url.searchParams.get('form_post_entry')).toBe('fp');
expect(url.searchParams.get('nonce')).toBe('n1');
expect(url.searchParams.get('RelayState')).toBe('rs');
expect(url.searchParams.get('responsekey')).toBe('rk');
expect(url.searchParams.get('scope')).toBe('openid');
expect(url.searchParams.get('suspendedId')).toBe('s1');
});
test('resume_WithPreviousStepInStorage_AllowsOptionsQueryToOverrideUrlParams', async () => {
const previousStepPayload: Step = {
callbacks: [{ type: callbackType.RedirectCallback, input: [], output: [] }],
};
mockStorageInstance.get.mockResolvedValue({ step: previousStepPayload });
const nextStepPayload: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(nextStepPayload);
const client = await journey({ config: mockConfig });
const resumeUrl = 'https://app.com/callback?code=123&state=abc';
await client.resume(resumeUrl, { query: { code: 'override' } });
const request = mockFetch.mock.calls[1][0] as Request;
const url = new URL(request.url);
expect(url.searchParams.get('code')).toBe('override');
expect(url.searchParams.get('state')).toBe('abc');
});
test('resume_WithPlainStepObjectInStorage_CorrectlyResumes', async () => {
const plainStepPayload: Step = {
callbacks: [
{ type: callbackType.TextOutputCallback, output: [{ name: 'message', value: 'Hello' }] },
],
stage: 'testStage',
};
mockStorageInstance.get.mockResolvedValue({ step: plainStepPayload });
const nextStepPayload: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(nextStepPayload);
const client = await journey({ config: mockConfig });
const resumeUrl = 'https://app.com/callback?code=123&state=abc';
const step = await client.resume(resumeUrl, {});
expect(step).toBeDefined();
expect(mockStorageInstance.get).toHaveBeenCalledTimes(1);
expect(mockStorageInstance.remove).toHaveBeenCalledTimes(1);
expect(mockFetch).toHaveBeenCalledTimes(2);
const request = mockFetch.mock.calls[1][0] as Request;
expect(request.method).toBe('POST');
expect(await request.json()).toEqual(plainStepPayload);
expect(step).toHaveProperty('type', 'Step');
if (step && !isGenericError(step)) {
expect(step.payload).toEqual(nextStepPayload);
}
});
test('resume_PreviousStepRequiredButNotFound_ThrowsError', async () => {
mockStorageInstance.get.mockResolvedValue(undefined);
setupMockFetch();
const client = await journey({ config: mockConfig });
const resumeUrl = 'https://app.com/callback?code=123&state=abc';
await expect(client.resume(resumeUrl)).rejects.toThrow(
'Error: previous step information not found in storage for resume operation.',
);
expect(mockStorageInstance.get).toHaveBeenCalledTimes(1);
expect(mockStorageInstance.remove).toHaveBeenCalledTimes(1);
});
test('resume_NoPreviousStepRequired_CallsStartWithUrlParams', async () => {
mockStorageInstance.get.mockResolvedValue(undefined);
const mockStepResponse: Step = { authId: 'test-auth-id', callbacks: [] };
setupMockFetch(mockStepResponse);
const client = await journey({ config: mockConfig });
const resumeUrl = 'https://app.com/callback?foo=bar';
const step = await client.resume(resumeUrl, {});
expect(step).toBeDefined();
expect(mockStorageInstance.get).not.toHaveBeenCalled();
expect(mockFetch).toHaveBeenCalledTimes(2); // wellknown + start
const request = mockFetch.mock.calls[1][0] as Request;
const url = new URL(request.url);
expect(url.origin + url.pathname).toBe('https://test.com/am/json/realms/root/authenticate');
expect(step).toHaveProperty('type', 'Step');
if (step && !isGenericError(step)) {
expect(step.payload).toEqual(mockStepResponse);
}
});
});
test('start_NoDataFromServer_ReturnsGenericError', async () => {
setupMockFetch(null);
const client = await journey({ config: mockConfig });
const result = await client.start();
expect(isGenericError(result)).toBe(true);
if (isGenericError(result)) {
expect(result.error).toBe('no_response_data');
expect(result.type).toBe('unknown_error');
}
});
describe('baseUrl from convertWellknown', () => {
test('journey_LocalhostWellknown_ConstructsCorrectUrls', async () => {
const localhostConfig: JourneyClientConfig = {
serverConfig: {
wellknown: 'http://localhost:9443/am/oauth2/realms/root/.well-known/openid-configuration',
},
};
const mockStepResponse: Step = { authId: 'test-auth-id', callbacks: [] };
mockFetch.mockImplementation((input: RequestInfo | URL) => {
const url = getUrlFromInput(input);
if (url.includes('.well-known')) {
return Promise.resolve(
new Response(
JSON.stringify({
...mockWellknownResponse,
issuer: 'http://localhost:9443/am/oauth2/realms/root',
authorization_endpoint: 'http://localhost:9443/am/oauth2/realms/root/authorize',
}),
),
);
}
return Promise.resolve(new Response(JSON.stringify(mockStepResponse)));
});
const client = await journey({ config: localhostConfig });
await client.start();
expect(mockFetch).toHaveBeenCalledTimes(2);
const request = mockFetch.mock.calls[1][0] as Request;
expect(request.url).toBe('http://localhost:9443/am/json/realms/root/authenticate');
});
});
describe('config property warnings', () => {
test('journey_ExtraConfigProperties_LogsWarning', async () => {
setupMockFetch();
const customLogger = {
error: vi.fn(),
warn: vi.fn(),
info: vi.fn(),
debug: vi.fn(),
};
await journey({
config: {
serverConfig: { wellknown: mockWellknownUrl },
clientId: 'test-client',
scope: 'openid',
redirectUri: 'https://example.com/callback',
},
logger: { level: 'warn', custom: customLogger },
});
expect(customLogger.warn).toHaveBeenCalledTimes(1);
expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('clientId'));
expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('scope'));
expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('redirectUri'));
});
test('journey_SingleIgnoredProperty_LogsWarning', async () => {
setupMockFetch();
const customLogger = {
error: vi.fn(),
warn: vi.fn(),
info: vi.fn(),
debug: vi.fn(),
};
await journey({
config: {
serverConfig: { wellknown: mockWellknownUrl },
clientId: 'test-client',
},
logger: { level: 'warn', custom: customLogger },
});
expect(customLogger.warn).toHaveBeenCalledTimes(1);
expect(customLogger.warn).toHaveBeenCalledWith(expect.stringContaining('clientId'));
});
test('journey_MinimalConfig_NoWarning', async () => {
setupMockFetch();
const customLogger = {
error: vi.fn(),
warn: vi.fn(),
info: vi.fn(),
debug: vi.fn(),
};
await journey({
config: { serverConfig: { wellknown: mockWellknownUrl } },
logger: { level: 'warn', custom: customLogger },
});
expect(customLogger.warn).not.toHaveBeenCalled();
});
});
describe('subrealm inference', () => {
test('journey_WellknownWithSubrealm_DerivesCorrectPaths', async () => {
const alphaConfig: JourneyClientConfig = {
serverConfig: {
wellknown:
'https://test.com/am/oauth2/realms/root/realms/alpha/.well-known/openid-configuration',
},
};
const mockStepResponse: Step = { authId: 'test-auth-id', callbacks: [] };
mockFetch.mockImplementation((input: RequestInfo | URL) => {
const url = getUrlFromInput(input);
if (url.includes('.well-known')) {
return Promise.resolve(
new Response(
JSON.stringify({
...mockWellknownResponse,
issuer: 'https://test.com/am/oauth2/realms/root/realms/alpha',
authorization_endpoint:
'https://test.com/am/oauth2/realms/root/realms/alpha/authorize',
}),
),
);
}
return Promise.resolve(new Response(JSON.stringify(mockStepResponse)));
});
const client = await journey({ config: alphaConfig });
await client.start();
const request = mockFetch.mock.calls[1][0] as Request;
expect(request.url).toBe('https://test.com/am/json/realms/root/realms/alpha/authenticate');
});
});
});