Skip to content

Commit 18ceae1

Browse files
authored
Merge pull request #372 from ForgeRock/fix-oidc-client-e2e-tests
chore(oidc-client): fix e2e text assertions
2 parents 5e3c00d + af3833d commit 18ceae1

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

e2e/oidc-suites/src/login.spec.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ test.describe('PingAM login and get token tests', () => {
6969

7070
await clickButton('Login (Redirect)', 'https://openam-sdks.forgeblocks.com/');
7171

72-
await expect(page.getByText('invalid_client')).toBeDefined();
72+
await expect(page.getByText('invalid_client')).toBeVisible();
7373
});
7474
});
7575

@@ -129,10 +129,12 @@ test.describe('PingOne login and get token tests', () => {
129129

130130
await clickButton('Login (Redirect)', 'https://apps.pingone.ca/');
131131

132-
await expect(page.getByText('Error')).toBeDefined();
132+
await expect(page.getByText('Error')).toBeVisible();
133133
await expect(
134-
page.getByText('The request could not be completed. The requested resource was not found.'),
135-
).toBeDefined();
134+
page
135+
.getByText('The request could not be completed. The requested resource was not found.')
136+
.first(),
137+
).toBeVisible();
136138
});
137139

138140
test('login with pi.flow response mode', async ({ page }) => {

e2e/oidc-suites/src/user.spec.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ test.describe('User tests', () => {
3333

3434
await page.getByRole('button', { name: 'User Info' }).click();
3535
await expect(page.locator('#userInfo')).not.toBeEmpty();
36-
await expect(page.getByText('sdkuser')).toBeVisible();
36+
await expect(page.getByText('Sdk User')).toBeVisible();
37+
await expect(page.getByText('sdkuser@example.com')).toBeVisible();
3738
});
3839

3940
test('get user info from PingOne', async ({ page }) => {
@@ -54,5 +55,6 @@ test.describe('User tests', () => {
5455
await page.getByRole('button', { name: 'User Info' }).click();
5556
await expect(page.locator('#userInfo')).not.toBeEmpty();
5657
await expect(page.getByText('demouser')).toBeVisible();
58+
await expect(page.getByText('demouser@user.com')).toBeVisible();
5759
});
5860
});

0 commit comments

Comments
 (0)