fix(journey-client): remove undefined from JourneyResult return type

  The implementation already returns GenericError for empty server
  responses, so undefined was unreachable. Removing it aligns the type
  with the actual behavior and matches davinci-client and oidc-client
  conventions. Also strengthens the wellknown.utils.test.ts assertion
  helper with a properly typed parameter for compile-time narrowing.

Author: ryanbas21

packages/journey-client/src/lib/client.store.test.ts

@@ -341,6 +341,22 @@ describe('journey-client', () => {
     });
   });
 
+  test('start_NoDataFromServer_ReturnsGenericError', async () => {
+    // Arrange: server returns null for the authenticate endpoint
+    setupMockFetch(null);
+
+    // Act
+    const client = await journey({ config: mockConfig });
+    const result = await client.start();
+
+    // Assert
+    expect(isGenericError(result)).toBe(true);
+    if (isGenericError(result)) {
+      expect(result.error).toBe('no_response_data');
+      expect(result.type).toBe('unknown_error');
+    }
+  });
+
   describe('baseUrl from convertWellknown', () => {
     test('journey_LocalhostWellknown_ConstructsCorrectUrls', async () => {
       // Arrange

packages/journey-client/src/lib/client.store.ts

@@ -32,12 +32,7 @@ import type { JourneyLoginFailure } from './login-failure.utils.js';
 import type { JourneyLoginSuccess } from './login-success.utils.js';
 
 /** Result type for journey client methods. */
-type JourneyResult =
-  | JourneyStep
-  | JourneyLoginSuccess
-  | JourneyLoginFailure
-  | GenericError
-  | undefined;
+type JourneyResult = JourneyStep | JourneyLoginSuccess | JourneyLoginFailure | GenericError;
 
 /** The journey client instance returned by the `journey()` function. */
 export interface JourneyClient {

packages/journey-client/src/lib/wellknown.utils.test.ts

@@ -11,9 +11,12 @@ import { convertWellknown } from './wellknown.utils.js';
 import type { WellknownResponse } from '@forgerock/sdk-types';
 import type { ResolvedServerConfig } from './wellknown.utils.js';
 
-function assertResolved(result: unknown): asserts result is ResolvedServerConfig {
-  expect(result).toBeDefined();
-  expect(result).not.toHaveProperty('error');
+function assertResolvedConfig(
+  result: ReturnType<typeof convertWellknown>,
+): asserts result is ResolvedServerConfig {
+  if ('error' in result) {
+    throw new Error(`Expected ResolvedServerConfig but got GenericError: ${result.error}`);
+  }
 }
 
 function createMockWellknown(overrides: Partial<WellknownResponse> = {}): WellknownResponse {
@@ -40,7 +43,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://am.example.com');
         expect(result.paths.authenticate).toBe('/am/json/alpha/authenticate');
         expect(result.paths.sessions).toBe('/am/json/alpha/sessions/');
@@ -59,7 +62,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://test.com');
         expect(result.paths.authenticate).toBe('/am/json/realms/root/authenticate');
         expect(result.paths.sessions).toBe('/am/json/realms/root/sessions/');
@@ -78,7 +81,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://test.com');
         expect(result.paths.authenticate).toBe('/am/json/realms/root/realms/alpha/authenticate');
         expect(result.paths.sessions).toBe('/am/json/realms/root/realms/alpha/sessions/');
@@ -98,7 +101,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://test.com');
         expect(result.paths.authenticate).toBe(
           '/am/json/realms/root/realms/customers/realms/premium/authenticate',
@@ -121,7 +124,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://am.example.com:8443');
         expect(result.paths.authenticate).toBe('/am/json/alpha/authenticate');
       });
@@ -139,7 +142,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('https://am.example.com');
         expect(result.paths.authenticate).toBe('/json/alpha/authenticate');
         expect(result.paths.sessions).toBe('/json/alpha/sessions/');
@@ -197,7 +200,7 @@ describe('wellknown.utils', () => {
         const result = convertWellknown(data);
 
         // Assert
-        assertResolved(result);
+        assertResolvedConfig(result);
         expect(result.baseUrl).toBe('http://localhost:9443');
         expect(result.paths.authenticate).toBe('/am/json/realms/root/authenticate');
         expect(result.paths.sessions).toBe('/am/json/realms/root/sessions/');