Skip to content

Commit 273f4d9

Browse files
committed
fix(github-actions): address review comments for publish workflows
1 parent a42deac commit 273f4d9

3 files changed

Lines changed: 8 additions & 9 deletions

File tree

.github/actions/publish-beta/action.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,7 @@
11
name: 'Publish Beta Steps'
22
description: 'Steps to run when packages are not published (beta branch)'
33
inputs:
4-
branch:
5-
description: 'Branch/ref for PR creation'
6-
required: false
7-
default: 'main'
4+
85
runs:
96
using: 'composite'
107
steps:

.github/actions/publish-release/action.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,9 @@ runs:
1616
run: |
1717
raw='${{ inputs.publishedPackages }}'
1818
message=$(echo "$raw" | jq -r '.[] | "- \(.name) v\(.version)"')
19-
echo "message=$message" >> $GITHUB_OUTPUT
19+
echo "message<<EOF" >> $GITHUB_OUTPUT
20+
echo "$message" >> $GITHUB_OUTPUT
21+
echo "EOF" >> $GITHUB_OUTPUT
2022
2123
- name: Send to Slack Workflow
2224
uses: slackapi/slack-github-action@v2.0.0

.github/actions/setup/action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,10 @@ runs:
3838
run: npm install -g npm@latest
3939
shell: bash
4040

41+
- name: Setup pnpm config
42+
run: pnpm config set store-dir ${{ inputs.pnpm-cache-folder }} --global
43+
shell: bash
44+
4145
- name: Install dependencies
4246
run: pnpm install --frozen-lockfile
4347
shell: bash
@@ -62,10 +66,6 @@ runs:
6266

6367
- uses: nrwl/nx-set-shas@v4
6468

65-
- name: Setup pnpm config
66-
run: pnpm config set store-dir ${{ inputs.pnpm-cache-folder }}
67-
shell: bash
68-
6969
- name: Run Nx build/lint/test/e2e
7070
run: pnpm exec nx affected -t build lint test e2e-ci
7171
shell: bash

0 commit comments

Comments
 (0)