Skip to content

Commit 3a554c9

Browse files
committed
fix(davinci-client): fix collector value types and simplify node reducer imports
1 parent edc5b15 commit 3a554c9

9 files changed

Lines changed: 4181 additions & 5695 deletions

File tree

.changeset/little-lamps-float.md

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
---
2+
'@forgerock/davinci-client': patch
3+
---
4+
5+
Fixed collector value types and simplified node reducer imports
6+
7+
### `client.types.ts`
8+
9+
- Added `CollectorValueTypes` union type; replaces inline unions in `updateCollectorValues` action payload (`node.reducer.ts`) and the `update` method return closure (`client.store.ts`).
10+
11+
- Rewrote `CollectorValueType<T>` conditional type: grouped branches by return type (string, boolean, string[], specialized, category catch-alls), added `never` for `ActionCollector` and `NoValueCollector`, and added a `SingleValueAutoCollector` catch-all.
12+
13+
### `node.reducer.ts` / `client.store.ts`
14+
15+
- Replaced ~30 individual collector type imports with `Collectors` (from `node.types`) and `CollectorValueTypes` (from `client.types`), collapsing verbose inline union annotations to single-type references.

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -100,3 +100,5 @@ GEMINI.md
100100

101101
# Polaris
102102
.polaris-setup-progress.json
103+
.playwright-mcp
104+
.polaris/

0 commit comments

Comments
 (0)