test(davinci-client): fix e2e tests

Author: ancheetah

e2e/davinci-suites/src/middleware.test.ts

@@ -6,6 +6,7 @@
  */
 import { expect, test } from '@playwright/test';
 import { asyncEvents } from './utils/async-events.js';
+import { password, username } from './utils/demo-user.js';
 
 test('Test middleware on test page', async ({ page }) => {
   const networkArray = [];
@@ -24,6 +25,13 @@ test('Test middleware on test page', async ({ page }) => {
 
   await expect(page.getByText('Username/Password Form')).toBeVisible();
 
+  await page.getByLabel('Username').fill(username);
+  await page.getByLabel('Password').fill(password);
+
+  await page.getByRole('button', { name: 'Sign On' }).click();
+
+  await expect(page.getByText('Complete')).toBeVisible();
+
   const startRequest = networkArray.find((req) => req.url.includes('/authorize'));
   const nextRequest = networkArray.find((req) => req.url.includes('/customHTMLTemplate'));
 

e2e/davinci-suites/src/phone-number-field.test.ts

@@ -65,7 +65,7 @@ test('Login - add phone device - authenticate with phone device', async ({ page
    * Go to page
    ***/
   expect(page.url()).toContain(
-    'http://localhost:5829/?clientId=20dd0ed0-bb9b-4c8f-9a60-9ebeb4b348e',
+    'http://localhost:5829/?clientId=20dd0ed0-bb9b-4c8f-9a60-9ebeb4b348e0',
   );
 
   /**

packages/protect/src/lib/protect.ts

@@ -41,8 +41,6 @@ declare global {
  * @param {ProtectConfig} options - the configuration options for the PingOne Signals SDK
  * @returns {Promise<Protect>} - a set of methods to interact with the PingOne Signals SDK
  */
-// TODO: Handle initialization errors
-// TODO: changeset?
 export function protect(options: ProtectConfig): Protect {
   let protectApiInitialized = false;