fix(devtools-extension): remove Html wildcard import, clean up renderArrow signature

Author: ryanbas21

packages/devtools-extension/src/panel/src/FlowView.elm

@@ -1,6 +1,6 @@
 module FlowView exposing (view, viewPlaybackControls)
 
-import Html exposing (..)
+import Html exposing (Html)
 import Html.Attributes exposing (..)
 import Html.Events exposing (onClick)
 import JsonTree
@@ -91,9 +91,9 @@ viewRail events playbackIndex selectedNodeId =
             else
                 count * nodeSpacing + 60
     in
-    div [ Html.Attributes.class "fv-rail" ]
+    Html.div [ Html.Attributes.class "fv-rail" ]
         [ if List.isEmpty sdkNodes then
-            div [ Html.Attributes.class "fv-rail-empty" ] [ Html.text "No SDK nodes recorded yet." ]
+            Html.div [ Html.Attributes.class "fv-rail-empty" ] [ Html.text "No SDK nodes recorded yet." ]
 
           else
             Svg.svg
@@ -104,7 +104,7 @@ viewRail events playbackIndex selectedNodeId =
                 ]
                 (railDefs
                     :: List.concat (List.indexedMap (renderRailNode selectedNodeId) visibleNodes)
-                    ++ List.concat (List.indexedMap (renderArrow (List.length visibleNodes)) visibleNodes)
+                    ++ List.concat (List.indexedMap (\i _ -> renderArrow (List.length visibleNodes) i) visibleNodes)
                 )
         ]
 
@@ -220,8 +220,8 @@ renderRailNode selectedNodeId index event =
            ]
 
 
-renderArrow : Int -> Int -> AuthEvent -> List (Svg Msg)
-renderArrow total index _ =
+renderArrow : Int -> Int -> List (Svg Msg)
+renderArrow total index =
     if index >= total - 1 then
         []
 
@@ -265,7 +265,7 @@ viewDetail : List AuthEvent -> Maybe String -> Set String -> Html Msg
 viewDetail events selectedNodeId expandedSubRows =
     case selectedNodeId of
         Nothing ->
-            div [ Html.Attributes.class "fv-detail fv-detail-empty" ]
+            Html.div [ Html.Attributes.class "fv-detail fv-detail-empty" ]
                 [ Html.text "Select a node to see its details." ]
 
         Just nodeId ->
@@ -274,9 +274,9 @@ viewDetail events selectedNodeId expandedSubRows =
                     List.filter (\e -> e.causedBy == Just nodeId) events
                         |> List.sortBy .timestamp
             in
-            div [ Html.Attributes.class "fv-detail" ]
+            Html.div [ Html.Attributes.class "fv-detail" ]
                 (if List.isEmpty netEvents then
-                    [ div [ Html.Attributes.class "fv-no-data" ]
+                    [ Html.div [ Html.Attributes.class "fv-no-data" ]
                         [ Html.text "No network requests attributed to this node." ]
                     ]
 
@@ -325,17 +325,17 @@ viewNetGroup event expandedSubRows =
         requestKey =
             event.id ++ ":request"
     in
-    div [ Html.Attributes.class "fv-net-group" ]
-        [ div [ Html.Attributes.class "fv-net-group-header" ]
-            [ span [ Html.Attributes.class ("tl-meth " ++ methodClass event.method) ]
+    Html.div [ Html.Attributes.class "fv-net-group" ]
+        [ Html.div [ Html.Attributes.class "fv-net-group-header" ]
+            [ Html.span [ Html.Attributes.class ("tl-meth " ++ methodClass event.method) ]
                 [ Html.text (Maybe.withDefault "—" event.method) ]
-            , span [ Html.Attributes.class "fv-net-url" ] [ Html.text urlText ]
-            , span [ Html.Attributes.class ("fv-net-status " ++ statusClass event.status) ]
+            , Html.span [ Html.Attributes.class "fv-net-url" ] [ Html.text urlText ]
+            , Html.span [ Html.Attributes.class ("fv-net-status " ++ statusClass event.status) ]
                 [ Html.text statusText ]
-            , span [ Html.Attributes.class "fv-net-dur" ] [ Html.text durationText ]
+            , Html.span [ Html.Attributes.class "fv-net-dur" ] [ Html.text durationText ]
             ]
         , if not hasAny then
-            div [ Html.Attributes.class "fv-no-data" ] [ Html.text "No data captured for this request." ]
+            Html.div [ Html.Attributes.class "fv-no-data" ] [ Html.text "No data captured for this request." ]
 
           else
             Html.text ""
@@ -355,7 +355,7 @@ viewNetGroup event expandedSubRows =
                     Just cs ->
                         List.indexedMap
                             (\i c ->
-                                div [ Html.Attributes.class "coll-card" ]
+                                Html.div [ Html.Attributes.class "coll-card" ]
                                     [ JsonTree.view ("Collector " ++ String.fromInt (i + 1)) c ]
                             )
                             cs
@@ -384,14 +384,14 @@ viewSection key label expandedSubRows content =
         icon =
             if isOpen then "▼ " else "▶ "
     in
-    div []
-        [ div
+    Html.div []
+        [ Html.div
             [ Html.Attributes.class "fv-section-row"
             , Html.Events.onClick (ToggleSubRow key)
             ]
             [ Html.text (icon ++ label) ]
         , if isOpen then
-            div [ Html.Attributes.class "fv-section-body" ] content
+            Html.div [ Html.Attributes.class "fv-section-body" ] content
 
           else
             Html.text ""
@@ -403,7 +403,7 @@ viewSection key label expandedSubRows content =
 
 view : List AuthEvent -> Maybe Int -> Maybe String -> Set String -> Html Msg
 view events playbackIndex selectedNodeId expandedSubRows =
-    div [ Html.Attributes.class "fv-view" ]
+    Html.div [ Html.Attributes.class "fv-view" ]
         [ viewRail events playbackIndex selectedNodeId
         , viewDetail events selectedNodeId expandedSubRows
         ]
@@ -426,13 +426,13 @@ viewPlaybackControls events playbackIndex isPlaying =
                 Just n  -> "Step " ++ String.fromInt (n + 1) ++ " / " ++ String.fromInt total
                 Nothing -> ""
     in
-    div [ Html.Attributes.class "fv-playback-controls" ]
-        [ button [ Html.Events.onClick ResetPlayback, Html.Attributes.class "tb-btn" ] [ Html.text "◀◀" ]
+    Html.div [ Html.Attributes.class "fv-playback-controls" ]
+        [ Html.button [ Html.Events.onClick ResetPlayback, Html.Attributes.class "tb-btn" ] [ Html.text "◀◀" ]
         , if isPlaying then
-            button [ Html.Events.onClick StopPlayback, Html.Attributes.class "tb-btn" ] [ Html.text "⏸ Pause" ]
+            Html.button [ Html.Events.onClick StopPlayback, Html.Attributes.class "tb-btn" ] [ Html.text "⏸ Pause" ]
 
           else
-            button
+            Html.button
                 [ Html.Events.onClick StartPlayback
                 , Html.Attributes.class "tb-btn"
                 , Html.Attributes.disabled (List.isEmpty sdkNodes)
@@ -441,7 +441,7 @@ viewPlaybackControls events playbackIndex isPlaying =
                     (if playbackIndex == Nothing then "▶ Play" else "▶ Resume")
                 ]
         , if stepLabel /= "" then
-            span [ Html.Attributes.class "fv-step-label" ] [ Html.text stepLabel ]
+            Html.span [ Html.Attributes.class "fv-step-label" ] [ Html.text stepLabel ]
 
           else
             Html.text ""