fix(davinci-client): remove try/catch from update dispatch — errors are now state

Author: ryanbas21

packages/davinci-client/src/lib/client.store.ts

@@ -346,16 +346,8 @@ export async function davinci<ActionType extends ActionTypes = ActionTypes>({
           | FidoAuthenticationInputValue,
         index?: number,
       ) {
-        try {
-          store.dispatch(nodeSlice.actions.update({ id, value, index }));
-          return null;
-        } catch (err) {
-          const errorMessage = err instanceof Error ? err.message : String(err);
-          return {
-            type: 'internal_error',
-            error: { message: errorMessage, type: 'internal_error' },
-          };
-        }
+        store.dispatch(nodeSlice.actions.update({ id, value, index }));
+        return null;
       };
     },
 

packages/davinci-client/src/lib/node.reducer.test.ts

@@ -350,7 +350,7 @@ describe('The node collector reducer', () => {
     ]);
   });
 
-  it('should throw with no collectors', () => {
+  it('should add an UnknownCollector with error when no matching collector is found', () => {
     const action = {
       type: 'node/update',
       payload: {
@@ -378,7 +378,10 @@ describe('The node collector reducer', () => {
         },
       },
     ];
-    expect(() => nodeCollectorReducer(state, action)).toThrowError('No collector found to update');
+    const result = nodeCollectorReducer(state, action);
+    const errorCollector = result.find((c) => c.id === 'submit-1');
+    expect(errorCollector?.error).toBe('No collector found to update');
+    expect(errorCollector?.category).toBe('UnknownCollector');
   });
 
   it('should set error on ActionCollector when update is attempted', () => {