chore: fix-issues

ryanbas21 · ryanbas21 · commit a2c6b7852dcc · 2025-05-20T21:12:05.000-06:00
diff --git a/e2e/mock-api-v2/package.json b/e2e/mock-api-v2/package.json
@@ -6,6 +6,7 @@
   "type": "module",
   "main": "./dist/index.js",
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "serve": "node dist/e2e/mock-api-v2/src/main.js",
     "serve:dev": "nodemon dist/e2e/mock-api-v2/src/main.js",
diff --git a/nx.json b/nx.json
@@ -121,7 +121,7 @@
           "targetName": "typecheck"
         },
         "build": {
-          "targetName": "build",
+          "targetName": "nxBuild",
           "configName": "tsconfig.lib.json"
         }
       },
diff --git a/packages/davinci-client/package.json b/packages/davinci-client/package.json
@@ -17,6 +17,7 @@
   "typings": "./dist/src/index.d.ts",
   "files": ["dist", "!dist/tsconfig.lib.tsbuildinfo", "./LICENSE"],
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
@@ -35,19 +36,6 @@
     "access": "public"
   },
   "nx": {
-    "tags": ["scope:package"],
-    "targets": {
-      "build": {
-        "executor": "@nx/js:tsc",
-        "outputs": ["{options.outputPath}"],
-        "options": {
-          "outputPath": "packages/davinci-client/dist",
-          "main": "packages/davinci-client/src/index.ts",
-          "tsConfig": "packages/davinci-client/tsconfig.lib.json",
-          "generatePackageJson": false,
-          "assets": []
-        }
-      }
-    }
+    "tags": ["scope:package"]
   }
 }
diff --git a/packages/device-client/package.json b/packages/device-client/package.json
@@ -20,6 +20,7 @@
   "typings": "./dist/index.d.ts",
   "files": ["./dist"],
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
@@ -32,18 +33,6 @@
     "msw": "^2.5.1"
   },
   "nx": {
-    "targets": {
-      "build": {
-        "executor": "@nx/js:tsc",
-        "outputs": ["{options.outputPath}"],
-        "options": {
-          "outputPath": "packages/device-client/dist",
-          "main": "packages/device-client/src/index.ts",
-          "tsConfig": "packages/device-client/tsconfig.lib.json",
-          "generatePackageJson": false,
-          "assets": []
-        }
-      }
-    }
+    "tags": ["scope:package"]
   }
 }
diff --git a/packages/oidc-client/package.json b/packages/oidc-client/package.json
@@ -20,6 +20,7 @@
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
diff --git a/packages/sdk-effects/iframe-manager/package.json b/packages/sdk-effects/iframe-manager/package.json
@@ -19,6 +19,12 @@
   "main": "./dist/src/index.js",
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
+  "scripts": {
+    "build": "pnpm nx nxBuild",
+    "lint": "pnpm nx nxLint",
+    "test": "pnpm nx nxTest",
+    "test:watch": "pnpm nx nxTest --watch"
+  },
   "dependencies": {},
   "nx": {
     "tags": ["scope:sdk-effects"]
diff --git a/packages/sdk-effects/iframe-manager/vite.config.ts b/packages/sdk-effects/iframe-manager/vite.config.ts
@@ -9,6 +9,7 @@ export default defineConfig(() => ({
   //  plugins: [ nxViteTsPaths() ],
   // },
   test: {
+    passWithNoTests: true,
     watch: false,
     globals: true,
     environment: 'node',
diff --git a/packages/sdk-effects/logger/package.json b/packages/sdk-effects/logger/package.json
@@ -20,6 +20,7 @@
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
diff --git a/packages/sdk-effects/oidc/package.json b/packages/sdk-effects/oidc/package.json
@@ -20,6 +20,7 @@
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
diff --git a/packages/sdk-effects/sdk-request-middleware/package.json b/packages/sdk-effects/sdk-request-middleware/package.json
@@ -20,6 +20,7 @@
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
diff --git a/packages/sdk-effects/storage/package.json b/packages/sdk-effects/storage/package.json
@@ -19,6 +19,12 @@
   "main": "./dist/src/index.js",
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
+  "scripts": {
+    "build": "pnpm nx nxBuild",
+    "lint": "pnpm nx nxLint",
+    "test": "pnpm nx nxTest",
+    "test:watch": "pnpm nx nxTest --watch"
+  },
   "dependencies": {
     "@forgerock/sdk-types": "workspace:*"
   },
diff --git a/packages/sdk-effects/storage/src/lib/storage.effects.test.ts b/packages/sdk-effects/storage/src/lib/storage.effects.test.ts
@@ -46,9 +46,15 @@ Object.defineProperty(global, 'localStorage', { value: localStorageMock });
 const sessionStorageMock = (() => {
   let store: Record<string, string> = {};
   return {
-    getItem: vi.fn((key: string) => Promise.resolve(store[key] || null)),
+    getItem: vi.fn((key: string) => {
+      const value = store[key];
+      if (value === undefined || value === null) {
+        return Promise.resolve(null);
+      }
+      return Promise.resolve(JSON.parse(value));
+    }),
     setItem: vi.fn((key: string, value: string) => {
-      store[key] = value;
+      store[key] = JSON.stringify(value);
       return Promise.resolve();
     }),
     removeItem: vi.fn((key: string) => {
@@ -201,8 +207,11 @@ describe('storage Effect', () => {
     it('should call sessionStorage.setItem with the correct key and value', async () => {
       await storageInstance.set(testValue);
       expect(sessionStorageMock.setItem).toHaveBeenCalledTimes(1);
-      expect(sessionStorageMock.setItem).toHaveBeenCalledWith(expectedKey, testValue);
-      expect(await sessionStorageMock.getItem(expectedKey)).toBe(testValue);
+      expect(sessionStorageMock.setItem).toHaveBeenCalledWith(
+        expectedKey,
+        JSON.stringify(testValue),
+      );
+      expect(await sessionStorageMock.getItem(expectedKey)).toBe(JSON.stringify(testValue));
       expect(localStorageMock.setItem).not.toHaveBeenCalled();
       expect(mockCustomStore.set).not.toHaveBeenCalled();
     });
diff --git a/packages/sdk-effects/storage/tsconfig.lib.json b/packages/sdk-effects/storage/tsconfig.lib.json
@@ -5,6 +5,8 @@
     "outDir": "dist",
     "tsBuildInfoFile": "dist/tsconfig.lib.tsbuildinfo",
     "emitDeclarationOnly": false,
+    "declaration": true,
+    "declarationMap": true,
     "module": "nodenext",
     "moduleResolution": "nodenext",
     "forceConsistentCasingInFileNames": true,
diff --git a/packages/sdk-types/package.json b/packages/sdk-types/package.json
@@ -20,8 +20,14 @@
   "module": "./dist/src/index.js",
   "types": "./dist/src/index.d.ts",
   "files": ["dist"],
+  "scripts": {
+    "build": "pnpm nx nxBuild",
+    "lint": "pnpm nx nxLint",
+    "test": "pnpm nx nxTest",
+    "test:watch": "pnpm nx nxTest --watch"
+  },
+  "dependencies": {},
   "nx": {
-    "tags": ["scope:sdk-types"],
-    "name": "@forgerock/sdk-types"
+    "tags": ["scope:sdk-types"]
   }
 }
diff --git a/packages/sdk-types/vite.config.ts b/packages/sdk-types/vite.config.ts
@@ -9,6 +9,7 @@ export default defineConfig(() => ({
   //  plugins: [ nxViteTsPaths() ],
   // },
   test: {
+    passWithNoTests: true,
     watch: false,
     globals: true,
     environment: 'node',
diff --git a/packages/sdk-utilities/package.json b/packages/sdk-utilities/package.json
@@ -22,11 +22,11 @@
   "module": "./dist/src/index.js",
   "files": ["dist"],
   "scripts": {
+    "build": "pnpm nx nxBuild",
     "lint": "pnpm nx nxLint",
     "test": "pnpm nx nxTest",
     "test:watch": "pnpm nx nxTest --watch"
   },
-  "dependencies": {},
   "nx": {
     "tags": ["scope:sdk-utilities"]
   }
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@`
`121`	`121`	`"targetName": "typecheck"`
`122`	`122`	`},`
`123`	`123`	`"build": {`
`124`		`- "targetName": "build",`
	`124`	`+ "targetName": "nxBuild",`
`125`	`125`	`"configName": "tsconfig.lib.json"`
`126`	`126`	`}`
`127`	`127`	`},`