Skip to content

Commit d6171f5

Browse files
committed
fix(ci): correct pnpm config setup and codecov token
Moves the "Setup pnpm config" step to before node setup for better ordering. Updates the CODECOV_TOKEN to use `secrets.CODECOV_TOKEN` instead of `env.CODECOV_TOKEN`. This improves security in the CI workflow.
1 parent a163aeb commit d6171f5

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

.github/actions/setup/action.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ runs:
2828
with:
2929
run_install: false
3030

31+
- name: Setup pnpm config
32+
run: pnpm config set store-dir ${{ inputs.pnpm-cache-folder }} --global
33+
shell: bash
34+
3135
- uses: actions/setup-node@v5
3236
with:
3337
node-version-file: ${{ inputs.node-version-file }}
@@ -38,10 +42,6 @@ runs:
3842
run: npm install -g npm@latest
3943
shell: bash
4044

41-
- name: Setup pnpm config
42-
run: pnpm config set store-dir ${{ inputs.pnpm-cache-folder }} --global
43-
shell: bash
44-
4545
- name: Install dependencies
4646
run: pnpm install --frozen-lockfile
4747
shell: bash
@@ -50,7 +50,7 @@ runs:
5050
run: pnpm dlx nx-cloud start-ci-run --distribute-on=".nx/workflows/dynamic-changesets.yml" --stop-agents-after="e2e-ci" --with-env-vars="CODECOV_TOKEN"
5151
shell: bash
5252
env:
53-
CODECOV_TOKEN: ${{ env.CODECOV_TOKEN }}
53+
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
5454

5555
- name: Cache Playwright browsers
5656
uses: actions/cache@v4

0 commit comments

Comments
 (0)