fix(journey-client): treat object error.data as LoginFailure and remove isStepLike

Author: vatsalparikh

packages/journey-client/src/lib/journey.utils.test.ts

@@ -56,14 +56,11 @@ describe('resolveJourneyResult - no_response_data', () => {
 });
 
 describe('toJourneyResult', () => {
-  it('returns request_failed GenericError for FetchBaseQueryError without Step payload', () => {
+  it('returns LoginFailure when FetchBaseQueryError has an object payload', () => {
     const result = resolveJourneyResult(undefined, { status: 500, data: { foo: 'bar' } });
 
-    expect(result).toMatchObject({
-      error: 'request_failed',
-      message: 'Request failed: {"foo":"bar"}',
-      type: 'unknown_error',
-    });
+    expect(result).toHaveProperty('type', StepType.LoginFailure);
+    expect(result).toHaveProperty('payload', { foo: 'bar' });
   });
 
   it('returns request_failed GenericError for SerializedError', () => {

packages/journey-client/src/lib/journey.utils.ts

@@ -55,35 +55,6 @@ export function createJourneyObject(
   }
 }
 
-/**
- * Type guard that checks whether a value resembles a Step response.
- * Used to detect step-shaped error payloads that should be treated as journey steps.
- *
- * @param value - The value to check
- * @returns True if the value is an object containing at least one known Step key
- */
-function isStepLike(value: unknown): boolean {
-  return (
-    typeof value === 'object' &&
-    value !== null &&
-    [
-      'authId',
-      'callbacks',
-      'code',
-      'description',
-      'detail',
-      'header',
-      'ok',
-      'realm',
-      'reason',
-      'stage',
-      'status',
-      'successUrl',
-      'tokenId',
-    ].some((key) => key in value)
-  );
-}
-
 /**
  * Maps an RTK Query dispatch result to a JourneyResult.
  * Narrows RTK errors first; only calls createJourneyObject when data is confirmed present.
@@ -98,7 +69,8 @@ export function resolveJourneyResult(
 ): JourneyResult {
   if (error && 'status' in error) {
     const stepData = error.data;
-    if (isStepLike(stepData)) {
+    // If error.data is an object, we treat it as login failure
+    if (typeof stepData === 'object' && stepData !== null) {
       return createJourneyObject(stepData as Step);
     }