fix(davinci-client): clear stale collector error on successful value update

Stale validation errors persisted in state after a user corrected their
input — a subsequent valid dispatch left the previous error message visible.
Mirror the pattern already used in pollCollectorValues by resetting
collector.error to null on every successful value-assignment path in
updateCollectorValues.

Author: ryanbas21

packages/davinci-client/src/lib/node.reducer.test.ts

@@ -473,6 +473,25 @@ describe('The node collector reducer', () => {
     );
   });
 
+  it('should clear error on collector when a valid value is provided after an error', () => {
+    const state: TextCollector[] = [
+      {
+        category: 'SingleValueCollector',
+        error: 'Value argument must be a string',
+        type: 'TextCollector',
+        id: 'username-0',
+        name: 'username',
+        input: { key: 'username', value: '', type: 'TEXT' },
+        output: { key: 'username', label: 'Username', type: 'TEXT', value: '' },
+      },
+    ];
+    const action = { type: 'node/update', payload: { id: 'username-0', value: 'validString' } };
+    const result = nodeCollectorReducer(state, action);
+    const collector = result.find((c) => c.id === 'username-0') as TextCollector | undefined;
+    expect(collector?.error).toBeNull();
+    expect(collector?.input.value).toBe('validString');
+  });
+
   it('should set error on SingleValueCollector when value is not a string', () => {
     const state: TextCollector[] = [
       {

packages/davinci-client/src/lib/node.reducer.ts

@@ -248,6 +248,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'Value argument must be a string';
           return;
         }
+        collector.error = null;
         collector.input.value = action.payload.value;
         return;
       }
@@ -257,6 +258,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'MultiValueCollector does not accept an object';
           return;
         }
+        collector.error = null;
         if (Array.isArray(action.payload.value)) {
           collector.input.value = [...action.payload.value];
         } else {
@@ -277,6 +279,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'No option found matching value to update';
           return;
         }
+        collector.error = null;
         collector.input.value = {
           type: option.type,
           id: option.value,
@@ -297,6 +300,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'No option found matching value to update';
           return;
         }
+        collector.error = null;
         collector.input.value = option.type;
         return;
       }
@@ -314,6 +318,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'Value argument must contain a phoneNumber and countryCode property';
           return;
         }
+        collector.error = null;
         collector.input.value = action.payload.value;
         return;
       }
@@ -336,6 +341,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
             'Value argument must contain a phoneNumber, countryCode, and extension property';
           return;
         }
+        collector.error = null;
         collector.input.value = action.payload.value;
         return;
       }
@@ -353,6 +359,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'Value argument must contain an attestationValue property';
           return;
         }
+        collector.error = null;
         collector.input.value = action.payload.value;
         return;
       }
@@ -370,6 +377,7 @@ export const nodeCollectorReducer = createReducer(initialCollectorValues, (build
           collector.error = 'Value argument must contain an assertionValue property';
           return;
         }
+        collector.error = null;
         collector.input.value = action.payload.value;
         return;
       }