refactor(oidc-client): merge effects.ts into micros.ts and µ-suffix all Micro exports

Consolidate authorize.request.effects.ts and existing micros into a single
file. Every function returning Micro is now µ-suffixed and uses braces +
explicit return for clarity.

Author: ryanbas21

packages/oidc-client/src/lib/authorize.request.effects.ts

@@ -10,21 +10,19 @@ import { vi, afterEach } from 'vitest';
 import * as sdkOidc from '@forgerock/sdk-oidc';
 import * as sdkUtilities from '@forgerock/sdk-utilities';
 
-import {
-  generateAuthValues,
-  generatePkceChallenge,
-  storeAuthOptions,
-} from './authorize.request.effects.js';
 import {
   buildParBody,
   validateParResponse,
   handleDispatchError,
   createAuthorizeUrlMicro,
 } from './authorize.request.utils.js';
 import {
-  buildParSlimUrl,
-  dispatchAuthorizeFetch,
-  dispatchAuthorizeIframe,
+  buildParSlimUrlµ,
+  dispatchAuthorizeFetchµ,
+  dispatchAuthorizeIframeµ,
+  generateAuthValuesµ,
+  generatePkceChallengeµ,
+  storeAuthOptionsµ,
 } from './authorize.request.micros.js';
 
 import type { OidcConfig } from './config.types.js';
@@ -62,12 +60,12 @@ afterEach(() => {
   vi.restoreAllMocks();
 });
 
-// ─── generateAuthValues ───────────────────────────────────────────────────────
+// ─── generateAuthValuesµ ───────────────────────────────────────────────────────
 
-it.effect('generateAuthValues returns auth URL options and store function', () =>
+it.effect('generateAuthValuesµ returns auth URL options and store function', () =>
   Micro.gen(function* () {
     vi.stubGlobal('sessionStorage', sessionStorageStub);
-    const result = yield* generateAuthValues(config, wellknown);
+    const result = yield* generateAuthValuesµ(config, wellknown);
     const [opts, storeFn] = result;
     expect(opts.clientId).toBe(clientId);
     expect(typeof opts.state).toBe('string');
@@ -76,39 +74,39 @@ it.effect('generateAuthValues returns auth URL options and store function', () =
   }),
 );
 
-it.effect('generateAuthValues fails with auth_error when sessionStorage throws', () =>
+it.effect('generateAuthValuesµ fails with auth_error when sessionStorage throws', () =>
   Micro.gen(function* () {
     vi.spyOn(sdkOidc, 'generateAndStoreAuthUrlValues').mockImplementation(() => {
       throw new Error('storage unavailable');
     });
-    const exit = yield* Micro.exit(generateAuthValues(config, wellknown));
+    const exit = yield* Micro.exit(generateAuthValuesµ(config, wellknown));
     expect(Micro.exitIsFailure(exit)).toBe(true);
     if (!Micro.exitIsFailure(exit) || !Micro.causeIsFail(exit.cause)) return;
     expect(exit.cause.error.type).toBe('auth_error');
     expect(exit.cause.error.error).toBe('PAR_PARAM_BUILD_ERROR');
   }),
 );
 
-// ─── generatePkceChallenge ────────────────────────────────────────────────────
+// ─── generatePkceChallengeµ ────────────────────────────────────────────────────
 
-it.effect('generatePkceChallenge returns a non-empty challenge string', () =>
+it.effect('generatePkceChallengeµ returns a non-empty challenge string', () =>
   Micro.gen(function* () {
     vi.stubGlobal('crypto', {
       subtle: {
         digest: vi.fn().mockResolvedValue(new ArrayBuffer(32)),
       },
       getRandomValues: vi.fn((arr: Uint8Array) => arr.fill(1)),
     });
-    const challenge = yield* generatePkceChallenge('test-verifier');
+    const challenge = yield* generatePkceChallengeµ('test-verifier');
     expect(typeof challenge).toBe('string');
     expect(challenge.length).toBeGreaterThan(0);
   }),
 );
 
-it.effect('generatePkceChallenge fails with auth_error when createChallenge throws', () =>
+it.effect('generatePkceChallengeµ fails with auth_error when createChallenge throws', () =>
   Micro.gen(function* () {
     vi.spyOn(sdkUtilities, 'createChallenge').mockRejectedValue(new Error('crypto unavailable'));
-    const exit = yield* Micro.exit(generatePkceChallenge('bad-verifier'));
+    const exit = yield* Micro.exit(generatePkceChallengeµ('bad-verifier'));
     expect(Micro.exitIsFailure(exit)).toBe(true);
     if (!Micro.exitIsFailure(exit) || !Micro.causeIsFail(exit.cause)) return;
     expect(exit.cause.error.type).toBe('auth_error');
@@ -149,11 +147,11 @@ it.effect('buildParBody fails with auth_error when buildAuthorizeParams throws',
   }),
 );
 
-// ─── buildParSlimUrl ──────────────────────────────────────────────────────────
+// ─── buildParSlimUrlµ ──────────────────────────────────────────────────────────
 
-it.effect('buildParSlimUrl returns URL with only client_id and request_uri', () =>
+it.effect('buildParSlimUrlµ returns URL with only client_id and request_uri', () =>
   Micro.gen(function* () {
-    const url = yield* buildParSlimUrl(
+    const url = yield* buildParSlimUrlµ(
       wellknown.authorization_endpoint,
       clientId,
       'urn:ietf:params:oauth:request_uri:abc123',
@@ -165,9 +163,9 @@ it.effect('buildParSlimUrl returns URL with only client_id and request_uri', ()
   }),
 );
 
-it.effect('buildParSlimUrl includes prompt when provided', () =>
+it.effect('buildParSlimUrlµ includes prompt when provided', () =>
   Micro.gen(function* () {
-    const url = yield* buildParSlimUrl(
+    const url = yield* buildParSlimUrlµ(
       wellknown.authorization_endpoint,
       clientId,
       'urn:ietf:params:oauth:request_uri:abc123',
@@ -177,20 +175,20 @@ it.effect('buildParSlimUrl includes prompt when provided', () =>
   }),
 );
 
-// ─── storeAuthOptions ─────────────────────────────────────────────────────────
+// ─── storeAuthOptionsµ ─────────────────────────────────────────────────────────
 
-it.effect('storeAuthOptions calls the provided store function', () =>
+it.effect('storeAuthOptionsµ calls the provided store function', () =>
   Micro.gen(function* () {
     const storeFn = vi.fn();
-    yield* storeAuthOptions(storeFn);
+    yield* storeAuthOptionsµ(storeFn);
     expect(storeFn).toHaveBeenCalledOnce();
   }),
 );
 
-it.effect('storeAuthOptions fails with unknown_error when store function throws', () =>
+it.effect('storeAuthOptionsµ fails with unknown_error when store function throws', () =>
   Micro.gen(function* () {
     const exit = yield* Micro.exit(
-      storeAuthOptions(() => {
+      storeAuthOptionsµ(() => {
         throw new Error('storage write failed');
       }),
     );
@@ -329,16 +327,16 @@ it.effect('handleDispatchError builds redirect URL for non-config errors', () =>
   }),
 );
 
-// ─── dispatchAuthorizeFetch ───────────────────────────────────────────────────
+// ─── dispatchAuthorizeFetchµ ───────────────────────────────────────────────────
 
-it.effect('dispatchAuthorizeFetch succeeds with authorizeResponse', () =>
+it.effect('dispatchAuthorizeFetchµ succeeds with authorizeResponse', () =>
   Micro.gen(function* () {
     const authorizeResponse = { code: 'auth-code-abc', state: 'state-xyz' };
     vi.mocked(mockStore.dispatch).mockResolvedValueOnce({
       data: { authorizeResponse },
     } as unknown as ReturnType<typeof mockStore.dispatch>);
 
-    const result = yield* dispatchAuthorizeFetch(
+    const result = yield* dispatchAuthorizeFetchµ(
       mockStore,
       'https://example.com/authorize?request_uri=...',
       wellknown,
@@ -349,15 +347,15 @@ it.effect('dispatchAuthorizeFetch succeeds with authorizeResponse', () =>
 );
 
 it.effect(
-  'dispatchAuthorizeFetch fails with unknown_error when data has no authorizeResponse',
+  'dispatchAuthorizeFetchµ fails with unknown_error when data has no authorizeResponse',
   () =>
     Micro.gen(function* () {
       vi.mocked(mockStore.dispatch).mockResolvedValueOnce({
         data: {},
       } as unknown as ReturnType<typeof mockStore.dispatch>);
 
       const exit = yield* Micro.exit(
-        dispatchAuthorizeFetch(mockStore, 'https://example.com/authorize', wellknown, {
+        dispatchAuthorizeFetchµ(mockStore, 'https://example.com/authorize', wellknown, {
           clientId,
           redirectUri,
           scope,
@@ -370,16 +368,16 @@ it.effect(
     }),
 );
 
-// ─── dispatchAuthorizeIframe ──────────────────────────────────────────────────
+// ─── dispatchAuthorizeIframeµ ──────────────────────────────────────────────────
 
-it.effect('dispatchAuthorizeIframe succeeds with iframe data', () =>
+it.effect('dispatchAuthorizeIframeµ succeeds with iframe data', () =>
   Micro.gen(function* () {
     const iframeData = { code: 'iframe-code', state: 'state-abc' };
     vi.mocked(mockStore.dispatch).mockResolvedValueOnce({
       data: iframeData,
     } as unknown as ReturnType<typeof mockStore.dispatch>);
 
-    const result = yield* dispatchAuthorizeIframe(
+    const result = yield* dispatchAuthorizeIframeµ(
       mockStore,
       'https://example.com/authorize',
       wellknown,
@@ -389,14 +387,14 @@ it.effect('dispatchAuthorizeIframe succeeds with iframe data', () =>
   }),
 );
 
-it.effect('dispatchAuthorizeIframe fails with unknown_error when data is undefined', () =>
+it.effect('dispatchAuthorizeIframeµ fails with unknown_error when data is undefined', () =>
   Micro.gen(function* () {
     vi.mocked(mockStore.dispatch).mockResolvedValueOnce({
       data: undefined,
     } as unknown as ReturnType<typeof mockStore.dispatch>);
 
     const exit = yield* Micro.exit(
-      dispatchAuthorizeIframe(mockStore, 'https://example.com/authorize', wellknown, {
+      dispatchAuthorizeIframeµ(mockStore, 'https://example.com/authorize', wellknown, {
         clientId,
         redirectUri,
         scope,
@@ -409,14 +407,14 @@ it.effect('dispatchAuthorizeIframe fails with unknown_error when data is undefin
   }),
 );
 
-it.effect('dispatchAuthorizeIframe fails with unknown_error when data has no code or state', () =>
+it.effect('dispatchAuthorizeIframeµ fails with unknown_error when data has no code or state', () =>
   Micro.gen(function* () {
     vi.mocked(mockStore.dispatch).mockResolvedValueOnce({
       data: { unexpected: 'shape' },
     } as unknown as ReturnType<typeof mockStore.dispatch>);
 
     const exit = yield* Micro.exit(
-      dispatchAuthorizeIframe(
+      dispatchAuthorizeIframeµ(
         mockStore,
         'https://example.com/authorize?foo=bar',
         wellknown,