chore(davinci-client): address remaining pr feedback

- Drop accidental .opensource/forgerock-javascript-sdk gitlink
- Reorder validate() in client.store so success branches follow all error checks
- Rename PASSWORD-with-policy reducer test for clarity

Author: ryanbas21

.opensource/forgerock-javascript-sdk

@@ -399,11 +399,8 @@ export async function davinci<ActionType extends ActionTypes = ActionTypes>({
         );
       }
 
-      if (collectorToUpdate.type === 'ValidatedPasswordCollector') {
-        return returnPasswordPolicyValidator(collectorToUpdate);
-      }
-
       if (
+        collectorToUpdate.type !== 'ValidatedPasswordCollector' &&
         collectorToUpdate.category !== 'ValidatedSingleValueCollector' &&
         collectorToUpdate.category !== 'ObjectValueCollector' &&
         collectorToUpdate.category !== 'MultiValueCollector' &&
@@ -416,14 +413,21 @@ export async function davinci<ActionType extends ActionTypes = ActionTypes>({
         );
       }
 
-      if (!('validation' in collectorToUpdate.input)) {
+      if (
+        collectorToUpdate.type !== 'ValidatedPasswordCollector' &&
+        !('validation' in collectorToUpdate.input)
+      ) {
         return handleUpdateValidateError(
           'Collector has no validation rules',
           'state_error',
           log.error,
         );
       }
 
+      if (collectorToUpdate.type === 'ValidatedPasswordCollector') {
+        return returnPasswordPolicyValidator(collectorToUpdate);
+      }
+
       return returnValidator(collectorToUpdate);
     },
 

packages/davinci-client/src/lib/client.store.ts

@@ -1313,7 +1313,7 @@ describe('PASSWORD_VERIFY with password policy', () => {
     expect((result[0] as ValidatedPasswordCollector).output.passwordPolicy).toEqual({});
   });
 
-  it('should produce PasswordCollector when a PASSWORD field carries a policy (policy ignored)', () => {
+  it('should ignore passwordPolicy on a PASSWORD field and produce a PasswordCollector', () => {
     const action = {
       type: 'node/next',
       payload: {