Skip to content

chore: add-header-to-src#192

Merged
ryanbas21 merged 1 commit into
mainfrom
add-headers
Apr 8, 2025
Merged

chore: add-header-to-src#192
ryanbas21 merged 1 commit into
mainfrom
add-headers

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/jira/software/c/projects/SDKS/boards/1234?selectedIssue=SDKS-3909

Description

Required to add a header to all files. this is just JS/TS files which should suffice for publishing purposes.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 31, 2025

⚠️ No Changeset found

Latest commit: c51af06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Mar 31, 2025

View your CI Pipeline Execution ↗ for commit c51af06.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 4m 11s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 4s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-08 17:47:21 UTC

Copy link
Copy Markdown
Collaborator

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but I believe we would need the full text to be compliant.

Comment thread commitlint.config.js Outdated
Comment on lines +1 to +5
/**
*
* Copyright © 2025 Ping Identity Corporation
*
**/
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this is the only text we need? The other platforms have a bit more to this copyright message: https://github.com/ForgeRock/ping-android-sdk/blob/develop/davinci/src/main/AndroidManifest.xml#L2

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the google drive document https://drive.google.com/file/d/1y4tn5lzd7el5hsOKsa06moXr_1Bg0-8e/view and when I spoke with legal it seemed this was sufficient.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2025

Deployed a7bfcb7 to https://ForgeRock.github.io/ping-javascript-sdk/pr-192/a7bfcb7f7bf3b5a3b7fde36e9c24185528925215 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.18%. Comparing base (e3235da) to head (b9e5cbc).
Report is 29 commits behind head on main.

Current head b9e5cbc differs from pull request most recent head c51af06

Please upload reports for the commit c51af06 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
- Coverage   50.59%   45.18%   -5.41%     
==========================================
  Files          24       33       +9     
  Lines        1354     1547     +193     
  Branches      177      186       +9     
==========================================
+ Hits          685      699      +14     
- Misses        669      848     +179     
Files with missing lines Coverage Δ
packages/davinci-client/src/index.ts 50.00% <100.00%> (+50.00%) ⬆️
packages/davinci-client/src/lib/authorize.utils.ts 3.44% <100.00%> (ø)
packages/davinci-client/src/lib/client.store.ts 0.45% <100.00%> (-0.01%) ⬇️
...kages/davinci-client/src/lib/client.store.utils.ts 3.44% <100.00%> (+3.44%) ⬆️
packages/davinci-client/src/lib/client.types.ts 100.00% <100.00%> (ø)
packages/davinci-client/src/lib/collector.types.ts 100.00% <100.00%> (ø)
packages/davinci-client/src/lib/collector.utils.ts 82.89% <ø> (ø)
packages/davinci-client/src/lib/config.slice.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/config.types.ts 100.00% <100.00%> (ø)
packages/davinci-client/src/lib/davinci.api.ts 0.45% <100.00%> (ø)
... and 23 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 merged commit 92079fc into main Apr 8, 2025
2 checks passed
@SteinGabriel SteinGabriel deleted the add-headers branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants