chore: add-header-to-src#192
Conversation
|
|
View your CI Pipeline Execution ↗ for commit c51af06.
☁️ Nx Cloud last updated this comment at |
cerebrl
left a comment
There was a problem hiding this comment.
This looks fine, but I believe we would need the full text to be compliant.
| /** | ||
| * | ||
| * Copyright © 2025 Ping Identity Corporation | ||
| * | ||
| **/ |
There was a problem hiding this comment.
Are we sure this is the only text we need? The other platforms have a bit more to this copyright message: https://github.com/ForgeRock/ping-android-sdk/blob/develop/davinci/src/main/AndroidManifest.xml#L2
There was a problem hiding this comment.
I followed the google drive document https://drive.google.com/file/d/1y4tn5lzd7el5hsOKsa06moXr_1Bg0-8e/view and when I spoke with legal it seemed this was sufficient.
|
Deployed a7bfcb7 to https://ForgeRock.github.io/ping-javascript-sdk/pr-192/a7bfcb7f7bf3b5a3b7fde36e9c24185528925215 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 50.59% 45.18% -5.41%
==========================================
Files 24 33 +9
Lines 1354 1547 +193
Branches 177 186 +9
==========================================
+ Hits 685 699 +14
- Misses 669 848 +179
🚀 New features to boost your workflow:
|
JIRA Ticket
https://pingidentity.atlassian.net/jira/software/c/projects/SDKS/boards/1234?selectedIssue=SDKS-3909
Description
Required to add a header to all files. this is just JS/TS files which should suffice for publishing purposes.