Skip to content

e2e: check for both messages#195

Merged
ryanbas21 merged 1 commit into
mainfrom
disable-test
Apr 3, 2025
Merged

e2e: check for both messages#195
ryanbas21 merged 1 commit into
mainfrom
disable-test

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

@ryanbas21 ryanbas21 commented Apr 1, 2025

JIRA Ticket

Description

Updating this because the test can have both messages because davinci responds differently sometimes. this allows the test to keep running and because the message isnt vital to our functionality

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 1, 2025

⚠️ No Changeset found

Latest commit: eb876e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 1, 2025

View your CI Pipeline Execution ↗ for commit eb876e5.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 2m 31s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-01 15:51:03 UTC

@ryanbas21 ryanbas21 force-pushed the disable-test branch 2 times, most recently from 80520f5 to 72cd7f0 Compare April 1, 2025 15:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 1, 2025

Deployed 23fd4e1 to https://ForgeRock.github.io/ping-javascript-sdk/pr-195/23fd4e147451171e1f043d62fd21faee51c096ba branch gh-pages in ForgeRock/ping-javascript-sdk

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it feels like a duplicate of the test we are skipping.

skipping this test because it is flakey as a result of a davinci bug

will update a bug report
@ryanbas21 ryanbas21 changed the title skip-flakey-test e2e: check for both messages Apr 1, 2025
@ryanbas21 ryanbas21 merged commit 71ac275 into main Apr 3, 2025
3 checks passed
@SteinGabriel SteinGabriel deleted the disable-test branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants