Skip to content

e2e: check for both messages #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbas21 merged 1 commit into from
Apr 3, 2025
Merged

e2e: check for both messages #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ jobs:
with:
name: playwright-report
path: |
./**/.playwright/**
**/.playwright
**/test-results
retention-days: 30

- name: build docs
Expand Down
2 changes: 1 addition & 1 deletion e2e/davinci-suites/src/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ test('Enter a bad username/password, then enter a good username/password', async

await page.getByRole('button', { name: 'Sign On' }).click();

await expect(page.getByText('Invalid username and/or password')).toBeVisible();
await expect(page.getByText(/Invalid username and\/or password|Validation Error/)).toBeVisible();

await page.getByRole('textbox', { name: 'Username' }).fill('e2euser@example.com');

Expand Down
18 changes: 0 additions & 18 deletions e2e/davinci-suites/src/error.test.ts
View file
Open in desktop
Copy link
Copy Markdown
Collaborator Author

@ryanbas21 ryanbas21 Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this because it feels like a duplicate of the test we are skipping.

This file was deleted.

Loading