Skip to content

chore: fix-imports#196

Merged
ryanbas21 merged 1 commit into
mainfrom
fix-pkg-json-exports
Apr 3, 2025
Merged

chore: fix-imports#196
ryanbas21 merged 1 commit into
mainfrom
fix-pkg-json-exports

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

JIRA Ticket

Description

Spent longer than I'm willing to admit trying to figure out why this wasn't resolving. must have been a carry over when we moved the packages over. Guess node or vite or whatever is resolving the package when I went to use it was using the incorrect keys (the ones with the wrong path).

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 2, 2025

⚠️ No Changeset found

Latest commit: 27ef7ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 2, 2025

View your CI Pipeline Execution ↗ for commit 27ef7ef.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 51s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-02 16:33:01 UTC

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Deployed 580da8a to https://ForgeRock.github.io/ping-javascript-sdk/pr-196/580da8a7252461c803f4026c90365e4c014b8aee branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.59%. Comparing base (1108234) to head (27ef7ef).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #196      +/-   ##
==========================================
+ Coverage   44.92%   50.59%   +5.66%     
==========================================
  Files          33       24       -9     
  Lines        1538     1354     -184     
  Branches      186      177       -9     
==========================================
- Hits          691      685       -6     
+ Misses        847      669     -178     

see 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ryanbas21 ryanbas21 merged commit e3235da into main Apr 3, 2025
4 checks passed
@SteinGabriel SteinGabriel deleted the fix-pkg-json-exports branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants