chore: refactor effects and utilities architecture and patterns#246
Conversation
🦋 Changeset detectedLatest commit: 0d54b34 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 0d54b34.
☁️ Nx Cloud last updated this comment at |
cerebrl
force-pushed
the
refactor_effects-utilities-arch
branch
from
f55bb63 to
60a3024
Compare
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
3 times, most recently
from
e4c8a5e to
0bd289e
Compare
|
Deployed 25ef011 to https://ForgeRock.github.io/ping-javascript-sdk/pr-246/25ef011d2fee1497e5f60b0346f43b6ba556c61c branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
+ Coverage 45.29% 47.35% +2.06%
==========================================
Files 33 29 -4
Lines 1550 1472 -78
Branches 187 148 -39
==========================================
- Hits 702 697 -5
+ Misses 848 775 -73
🚀 New features to boost your workflow:
|
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
from
075c43d to
6268772
Compare
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
from
6268772 to
324d6a6
Compare
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
from
2d24070 to
585d3cb
Compare
There was a problem hiding this comment.
Let's make sure to call the package sdk-effects.
There was a problem hiding this comment.
you want the logger to be called sdk-effects?
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
from
585d3cb to
be431a3
Compare
…ed-packages Ported over logger, oidc, and abstracted request middleware into own packages. As a result we created a shared types and and a utilities directory. Updated davinci-client to use these packages. Added copyright Co-authored-by: AJ Ancheta <ajancheta@pingidentity.com> Co-authored-by: Justin Lowery <justin.lowery@pingidentity.com>
ryanbas21
force-pushed
the
refactor_effects-utilities-arch
branch
from
be431a3 to
0d54b34
Compare
|
This looks good to me. I can't approve this since it's my own PR, so someone else will have to approve it. IMPORTANT: for future reference, please don't rewrite or squash other people's commits; only alter your own. Since three people contributed to this PR, I'd expect to see at least three commits (one for each author). |
| "test": { | ||
| "inputs": ["default", "^default", "noMarkdown", "^noMarkdown"], | ||
| "dependsOn": ["^test"], | ||
| "dependsOn": ["^test", "^build", "^build", "^build", "^build"], |
There was a problem hiding this comment.
how did build get in here so many times?
4 participants
This is just an example refactor for the effect and utility work done by @ryanbas21 and @ancheetah.