Release PR#257
Conversation
|
View your CI Pipeline Execution ↗ for commit adff721.
☁️ Nx Cloud last updated this comment at |
|
Deployed e8bcfac to https://ForgeRock.github.io/ping-javascript-sdk/pr-257/e8bcfac508febfe75ab940e78c1f8d72e020c245 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 53.46% 61.61% +8.14%
==========================================
Files 20 33 +13
Lines 1528 1985 +457
Branches 183 287 +104
==========================================
+ Hits 817 1223 +406
- Misses 711 762 +51 🚀 New features to boost your workflow:
|
4e04180 to
03a385d
Compare
5cf564f to
17eaac1
Compare
5871781 to
8317ff4
Compare
66d9b55 to
961de83
Compare
|
Looks good to me Ryan, thanks. |
brando-dill
left a comment
There was a problem hiding this comment.
Overall, nothing to big. A couple of notes; however:
- Ensure, where you can, to add the 'why' we did a change, if it can be put into a couple of words.
- Be consistent with casing, I noticed sometimes you capitalized starting the description, and other times you didn't .
|
|
||
| - [#293](https://github.com/ForgeRock/ping-javascript-sdk/pull/293) [`95d6bb9`](https://github.com/ForgeRock/ping-javascript-sdk/commit/95d6bb9db24bcbbccf29f415504840c6cc3faff3) Thanks [@cerebrl](https://github.com/cerebrl)! - Implement the logger module to DaVinci Client | ||
|
|
||
| - [#262](https://github.com/ForgeRock/ping-javascript-sdk/pull/262) [`e38b49e`](https://github.com/ForgeRock/ping-javascript-sdk/commit/e38b49ebd29c304cb362d77e3e9862217f1cc17a) Thanks [@cerebrl](https://github.com/cerebrl)! - Add support for MFA OTP field support with added collectors |
There was a problem hiding this comment.
Update this to - Provide MFA OTP support with PingOne Forms by adding support for the DeviceAuthentication and DeviceRegistration collectors
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware | ||
|
|
||
| - [#270](https://github.com/ForgeRock/ping-javascript-sdk/pull/270) [`4756348`](https://github.com/ForgeRock/ping-javascript-sdk/commit/475634870558309cf28fd3848a180e9753f0a9a0) Thanks [@cerebrl](https://github.com/cerebrl)! - Implemented phone number collector to support phone number field |
There was a problem hiding this comment.
To complete the MFA OTP use case with PingOne forms, implemented support for the PhoneNumber collector
|
|
||
| - [#262](https://github.com/ForgeRock/ping-javascript-sdk/pull/262) [`e38b49e`](https://github.com/ForgeRock/ping-javascript-sdk/commit/e38b49ebd29c304cb362d77e3e9862217f1cc17a) Thanks [@cerebrl](https://github.com/cerebrl)! - Add support for MFA OTP field support with added collectors | ||
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware |
There was a problem hiding this comment.
Created packages for effects, logging, OIDC, and request middleware
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware |
There was a problem hiding this comment.
Created packages for effects, logging, OIDC, and request middleware
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware | ||
|
|
||
| - [#293](https://github.com/ForgeRock/ping-javascript-sdk/pull/293) [`95d6bb9`](https://github.com/ForgeRock/ping-javascript-sdk/commit/95d6bb9db24bcbbccf29f415504840c6cc3faff3) Thanks [@cerebrl](https://github.com/cerebrl)! - Add custom logger API option to logger module |
There was a problem hiding this comment.
Added a custom logger API option to the logger module to.....
It is important to add the "why" we do something if we can.
|
|
||
| - [#253](https://github.com/ForgeRock/ping-javascript-sdk/pull/253) [`04b506c`](https://github.com/ForgeRock/ping-javascript-sdk/commit/04b506c2016324dffeba3a473bfc705843ac3e41) Thanks [@ryanbas21](https://github.com/ryanbas21)! - Adds IFrame manager package to be able to create iframes and parse search params from the iframe url. | ||
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware |
There was a problem hiding this comment.
Created packages for effects, logging, OIDC, and request middleware
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware |
There was a problem hiding this comment.
Created packages for effects, logging, OIDC, and request middleware
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#246](https://github.com/ForgeRock/ping-javascript-sdk/pull/246) [`0d54b34`](https://github.com/ForgeRock/ping-javascript-sdk/commit/0d54b3461443fcf5c5071a08578f2d418f066073) Thanks [@cerebrl](https://github.com/cerebrl)! - created effects type packages, logger, oidc, and request middleware |
There was a problem hiding this comment.
Created packages for effects, logging, OIDC, and request middleware
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#253](https://github.com/ForgeRock/ping-javascript-sdk/pull/253) [`04b506c`](https://github.com/ForgeRock/ping-javascript-sdk/commit/04b506c2016324dffeba3a473bfc705843ac3e41) Thanks [@ryanbas21](https://github.com/ryanbas21)! - Adds IFrame manager package to be able to create iframes and parse search params from the iframe url. |
|
|
||
| ### Patch Changes | ||
|
|
||
| - [#279](https://github.com/ForgeRock/ping-javascript-sdk/pull/279) [`ad03cd5`](https://github.com/ForgeRock/ping-javascript-sdk/commit/ad03cd567ce9364880d46162a1cb787deb2f8b15) Thanks [@ryanbas21](https://github.com/ryanbas21)! - adds token-store module to newly created oidc-client for generic oidc interactions. |
There was a problem hiding this comment.
For generic OIDC interactions, adds a token-store module to newly created OIDC clients
526a72c to
441e2e1
Compare
e515209 to
2a3f3f3
Compare
9128c91 to
f538607
Compare
f538607 to
adff721
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@forgerock/davinci-client@1.2.0
Minor Changes
#299
629d3e0Thanks @ryanbas21! - provide a client type that handles the awaiting of the davinci client initalization and a type for handling getClient call so consumers have the type available easily#293
95d6bb9Thanks @cerebrl! - Implement the logger module to DaVinci Client#262
e38b49eThanks @cerebrl! - Add support for MFA OTP field support with added collectors#246
0d54b34Thanks @cerebrl! - created effects type packages, logger, oidc, and request middleware#270
4756348Thanks @cerebrl! - Implemented phone number collector to support phone number fieldPatch Changes
#312
5d71457Thanks @ryanbas21! - Fixes the device-fields which were changed to options on the object#322
9a03632Thanks @ryanbas21! - Return a url from the externalIdp function for app developers to use to redirect their url#270
4756348Thanks @cerebrl! - Fixed bugs related to device auth and registration#277
fb041e0Thanks @ryanbas21! - error states should be cleared from state when a successful next or success node was processed#267
12179a1Thanks @ryanbas21! - update type misalignments and fallback tocontinuestate when there is no state given#331
d9dc175Thanks @ryanbas21! - export the InternalErrorResponse type#332
0ea7df7Thanks @ryanbas21! - add-back-node-states-apiUpdated dependencies [
04b506c,0d54b34,50fd7fa,95d6bb9]:@forgerock/iframe-manager@1.2.0
Minor Changes
04b506cThanks @ryanbas21! - Adds IFrame manager package to be able to create iframes and parse search params from the iframe url.@forgerock/sdk-logger@1.2.0
Minor Changes
#246
0d54b34Thanks @cerebrl! - created effects type packages, logger, oidc, and request middleware#293
95d6bb9Thanks @cerebrl! - Add custom logger API option to logger module@forgerock/sdk-oidc@1.2.0
Minor Changes
#253
04b506cThanks @ryanbas21! - Adds IFrame manager package to be able to create iframes and parse search params from the iframe url.#246
0d54b34Thanks @cerebrl! - created effects type packages, logger, oidc, and request middlewarePatch Changes
04b506c,0d54b34,50fd7fa]:@forgerock/sdk-request-middleware@1.2.0
Minor Changes
0d54b34Thanks @cerebrl! - created effects type packages, logger, oidc, and request middleware@forgerock/storage@1.2.0
Minor Changes
50fd7faThanks @ryanbas21! - created sdk-storage module, which includes session,local, and token storagePatch Changes
04b506c,50fd7fa]:@forgerock/sdk-types@1.2.0
Minor Changes
#253
04b506cThanks @ryanbas21! - Adds IFrame manager package to be able to create iframes and parse search params from the iframe url.#251
50fd7faThanks @ryanbas21! - created sdk-storage module, which includes session,local, and token storage@forgerock/sdk-utilities@1.2.0
Minor Changes
0d54b34Thanks @cerebrl! - created effects type packages, logger, oidc, and request middleware@forgerock/oidc-client@1.2.0
Patch Changes
#279
ad03cd5Thanks @ryanbas21! - adds token-store module to newly created oidc-client for generic oidc interactions.Updated dependencies [
04b506c,50fd7fa]: