feat(davinci-client): implement phone number field support#270
Conversation
Also fixed some minor bugs with device auth and registration as well as implemented component support for phone, device auth and reg in sample/test app.
🦋 Changeset detectedLatest commit: 1167ca2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 1167ca2.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
==========================================
+ Coverage 49.33% 56.49% +7.16%
==========================================
Files 29 20 -9
Lines 1571 1439 -132
Branches 173 187 +14
==========================================
+ Hits 775 813 +38
+ Misses 796 626 -170
🚀 New features to boost your workflow:
|
|
Deployed 811817a to https://ForgeRock.github.io/ping-javascript-sdk/pr-270/811817a4a2bb1b699ea139e09194ebeec9fb724b branch gh-pages in ForgeRock/ping-javascript-sdk |
| formEl, // You can ignore this; it's just for rendering | ||
| collector, // This is the plain object of the collector | ||
| ); | ||
| } else if (collector.type === 'PhoneNumberCollector') { |
There was a problem hiding this comment.
i know this doesn't have to be separated so we can remove this and add the if condition above but i just separated it for reading
1b4a701 to
685beec
Compare
cerebrl
left a comment
There was a problem hiding this comment.
LGTM. I can't approve it since I made the PR, so @ryanbas21 or @ancheetah will need to approve it.
Also fixed some minor bugs with device auth and registration as well as implemented component support for phone, device auth and reg in sample/test app.
JIRA Ticket
Description