Skip to content

feat(davinci-client): implement phone number field support#270

Merged
ryanbas21 merged 4 commits into
mainfrom
feat_phone-number-component
May 16, 2025
Merged

feat(davinci-client): implement phone number field support#270
ryanbas21 merged 4 commits into
mainfrom
feat_phone-number-component

Conversation

@cerebrl
Copy link
Copy Markdown
Collaborator

@cerebrl cerebrl commented May 4, 2025

Also fixed some minor bugs with device auth and registration as well as implemented component support for phone, device auth and reg in sample/test app.

JIRA Ticket

Description

Also fixed some minor bugs with device auth and registration as well as
implemented component support for phone, device auth and reg in
sample/test app.
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 4, 2025

🦋 Changeset detected

Latest commit: 1167ca2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@forgerock/davinci-client Minor
@forgerock/sdk-types Minor
@forgerock/sdk-utilities Minor
@forgerock/iframe-manager Minor
@forgerock/sdk-logger Minor
@forgerock/sdk-oidc Minor
@forgerock/sdk-request-middleware Minor
@forgerock/storage Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 4, 2025

View your CI Pipeline Execution ↗ for commit 1167ca2.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 23s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 16:49:53 UTC

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 4, 2025

Codecov Report

Attention: Patch coverage is 88.73239% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.49%. Comparing base (6bc605b) to head (1167ca2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/davinci-client/src/lib/collector.utils.ts 89.58% 5 Missing ⚠️
packages/davinci-client/src/lib/node.reducer.ts 90.00% 2 Missing ⚠️
packages/davinci-client/src/lib/client.store.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #270      +/-   ##
==========================================
+ Coverage   49.33%   56.49%   +7.16%     
==========================================
  Files          29       20       -9     
  Lines        1571     1439     -132     
  Branches      173      187      +14     
==========================================
+ Hits          775      813      +38     
+ Misses        796      626     -170     
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/client.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/collector.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/davinci.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/lib/davinci.utils.ts 92.40% <100.00%> (-0.59%) ⬇️
packages/davinci-client/src/lib/node.types.ts 100.00% <ø> (ø)
packages/davinci-client/src/types.ts 50.00% <ø> (ø)
packages/davinci-client/src/lib/client.store.ts 0.43% <0.00%> (ø)
packages/davinci-client/src/lib/node.reducer.ts 77.77% <90.00%> (+2.18%) ⬆️
packages/davinci-client/src/lib/collector.utils.ts 84.97% <89.58%> (-0.14%) ⬇️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2025

Deployed 811817a to https://ForgeRock.github.io/ping-javascript-sdk/pr-270/811817a4a2bb1b699ea139e09194ebeec9fb724b branch gh-pages in ForgeRock/ping-javascript-sdk

Comment thread e2e/davinci-app/main.ts
formEl, // You can ignore this; it's just for rendering
collector, // This is the plain object of the collector
);
} else if (collector.type === 'PhoneNumberCollector') {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this doesn't have to be separated so we can remove this and add the if condition above but i just separated it for reading

@ryanbas21 ryanbas21 force-pushed the feat_phone-number-component branch from 1b4a701 to 685beec Compare May 6, 2025 19:41
Copy link
Copy Markdown
Collaborator Author

@cerebrl cerebrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I can't approve it since I made the PR, so @ryanbas21 or @ancheetah will need to approve it.

@ryanbas21 ryanbas21 merged commit 0c6466c into main May 16, 2025
3 checks passed
@ryanbas21 ryanbas21 mentioned this pull request May 16, 2025
@SteinGabriel SteinGabriel deleted the feat_phone-number-component branch April 17, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants