Skip to content

chore: fix-formatting#275

Merged
ryanbas21 merged 1 commit into
mainfrom
fix-publish-ci
May 9, 2025
Merged

chore: fix-formatting#275
ryanbas21 merged 1 commit into
mainfrom
fix-publish-ci

Conversation

@ryanbas21

Copy link
Copy Markdown
Collaborator

JIRA Ticket

Description

Nx uses the base and head sha's from the set-sha's action which is causing nx format:write to effectively not run on the newly changed files.

@changeset-bot

changeset-bot Bot commented May 9, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f45c638

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud

nx-cloud Bot commented May 9, 2025

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit f45c638.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 13s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-09 19:25:58 UTC

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.33%. Comparing base (6bc605b) to head (f45c638).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   49.33%   49.33%           
=======================================
  Files          29       29           
  Lines        1571     1571           
  Branches      173      173           
=======================================
  Hits          775      775           
  Misses        796      796           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown
Contributor

Deployed 4ef4aa6 to https://ForgeRock.github.io/ping-javascript-sdk/pr-275/4ef4aa6b949329c1adc4b9587da9a83057d17869 branch gh-pages in ForgeRock/ping-javascript-sdk

@ryanbas21 ryanbas21 marked this pull request as ready for review May 9, 2025 19:27

@spetrov spetrov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@ryanbas21 ryanbas21 merged commit a95acca into main May 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants