fix: filter-undefined-keys#278
Conversation
🦋 Changeset detectedLatest commit: 30fe3c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 30fe3c1.
☁️ Nx Cloud last updated this comment at |
|
Deployed 1133505 to https://ForgeRock.github.io/ping-javascript-sdk/pr-278/11335050fb49a8bd26235c098630674a7df00f51 branch gh-pages in ForgeRock/ping-javascript-sdk |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
==========================================
+ Coverage 49.33% 55.62% +6.29%
==========================================
Files 29 20 -9
Lines 1571 1386 -185
Branches 173 164 -9
==========================================
- Hits 775 771 -4
+ Misses 796 615 -181
🚀 New features to boost your workflow:
|
| if (collector?.input?.key) { | ||
| acc[collector.input.key] = collector.input.value; | ||
| } |
There was a problem hiding this comment.
I know we talked about this before, but I'd like to avoid doing this. We should have filtered OUT any collectors that don't have a key value. So, if we are doing this here, we're not doing something right in what comes before this. Can we look at why we are getting key-less collectors here?

JIRA Ticket
https://pingidentity.atlassian.net/browse/SDKS-3994
Description
When we receive a collector that is not meant to be sent back int he response, we should ensure we aren't adding "undefined" to the response data keys