Skip to content

fix: filter-undefined-keys#278

Closed
ryanbas21 wants to merge 1 commit into
mainfrom
form-data-undefined
Closed

fix: filter-undefined-keys#278
ryanbas21 wants to merge 1 commit into
mainfrom
form-data-undefined

Conversation

@ryanbas21
Copy link
Copy Markdown
Collaborator

JIRA Ticket

https://pingidentity.atlassian.net/browse/SDKS-3994

Description

When we receive a collector that is not meant to be sent back int he response, we should ensure we aren't adding "undefined" to the response data keys

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 13, 2025

🦋 Changeset detected

Latest commit: 30fe3c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@forgerock/davinci-client Patch
@forgerock/sdk-types Patch
@forgerock/sdk-utilities Patch
@forgerock/iframe-manager Patch
@forgerock/sdk-logger Patch
@forgerock/sdk-oidc Patch
@forgerock/sdk-request-middleware Patch
@forgerock/storage Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented May 13, 2025

View your CI Pipeline Execution ↗ for commit 30fe3c1.

Command Status Duration Result
nx affected -t build typecheck lint test e2e-ci ✅ Succeeded 1m 23s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-13 19:22:25 UTC

@github-actions
Copy link
Copy Markdown
Contributor

Deployed 1133505 to https://ForgeRock.github.io/ping-javascript-sdk/pr-278/11335050fb49a8bd26235c098630674a7df00f51 branch gh-pages in ForgeRock/ping-javascript-sdk

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.62%. Comparing base (dd5af9a) to head (30fe3c1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   49.33%   55.62%   +6.29%     
==========================================
  Files          29       20       -9     
  Lines        1571     1386     -185     
  Branches      173      164       -9     
==========================================
- Hits          775      771       -4     
+ Misses        796      615     -181     
Files with missing lines Coverage Δ
packages/davinci-client/src/lib/davinci.utils.ts 94.96% <100.00%> (+1.97%) ⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines +44 to +46
if (collector?.input?.key) {
acc[collector.input.key] = collector.input.value;
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we talked about this before, but I'd like to avoid doing this. We should have filtered OUT any collectors that don't have a key value. So, if we are doing this here, we're not doing something right in what comes before this. Can we look at why we are getting key-less collectors here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess i don't see where we do that.

Screenshot 2025-05-15 at 1 27 58 PM

this is the only place in the codebase, within packages where we even dive into the input key like this.

Am I looking for the wrong thing?

@ryanbas21 ryanbas21 closed this May 20, 2025
@SteinGabriel SteinGabriel deleted the form-data-undefined branch April 17, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants